Re: [PATCH v2 0/6] thermal: tegra: soctherm bugfixes

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3348 bytes --]

On Thu, Nov 19, 2020 at 12:04:34PM +0100, Daniel Lezcano wrote:
> On 19/11/2020 12:00, Nicolas Chauvet wrote:
> > Le dim. 27 sept. 2020 à 17:10, Nicolas Chauvet <kwizart@gmail.com> a écrit :
> >>
> >> When using tegra_soctherm driver on jetson-tk1, the following messages
> >> can be seen:
> >> from kernel: tegra_soctherm 700e2000.thermal-sensor:
> >>  throttle-cfg: heavy: no throt prop or invalid prop
> >>  soctherm: trip temperature -2147483647 forced to -127000
> >>  thermtrip: will shut down when cpu reaches 101000 mC
> >>  soctherm: trip temperature -2147483647 forced to -127000
> >>  thermtrip: will shut down when gpu reaches 101000 mC
> >>  soctherm: trip temperature -2147483647 forced to -127000
> >>  thermtrip: will shut down when pll reaches 103000 mC
> >>  throttrip: pll: missing hot temperature
> >>  soctherm: trip temperature -2147483647 forced to -127000
> >>  thermtrip: will shut down when mem reaches 101000 mC
> >>  throttrip: mem: missing hot temperature
> >>  IRQ index 1 not found
> >>
> >> This serie fixes two errors and two warnings that are reported in dmesg
> >> It was compiled and tested at runtime on jetson-tk1 only.
> >>
> >>
> >> v2:
> >>  * Add missing tegra210 device-tree properties
> >>  * Add the appropriate prefix for tegra soctherm
> >>  * Use SoCs condition over of_compatible
> >>
> >>
> >> Nicolas Chauvet (6):
> >>   ARM: tegra: Add missing gpu-throt-level to tegra124 soctherm
> >>   ARM: tegra: Add missing hot temperatures to tegra124 thermal-zones
> >>   arm64: tegra: Add missing hot temperatures to tegra132 thermal-zones
> >>   arm64: tegra: Add missing gpu-throt-level to tegra210 soctherm
> >>   arm64: tegra: Add missing hot temperatures to tegra210 thermal-zones
> >>   thermal: tegra: Avoid setting edp_irq when not relevant
> >>
> >>  arch/arm/boot/dts/tegra124.dtsi           | 11 +++++++
> >>  arch/arm64/boot/dts/nvidia/tegra132.dtsi  | 10 ++++++
> >>  arch/arm64/boot/dts/nvidia/tegra210.dtsi  | 13 ++++++++
> >>  drivers/thermal/tegra/soctherm.c          | 38 +++++++++++++----------
> >>  drivers/thermal/tegra/soctherm.h          |  1 +
> >>  drivers/thermal/tegra/tegra124-soctherm.c |  1 +
> >>  drivers/thermal/tegra/tegra132-soctherm.c |  1 +
> >>  drivers/thermal/tegra/tegra210-soctherm.c |  1 +
> >>  8 files changed, 60 insertions(+), 16 deletions(-)
> >>
> >> --
> >> 2.25.4
> > 
> > Hello,
> > This series is still pending review.
> > 
> > Thierry, do you expect some reviewers from the linux-pm (Zhang, Daniel ?)
> > To me it seems like tegra specific changes, so maybe a Nvidia reviewer
> > is awaited ?
> 
> I can apply the patch 6/6, other patches must go through arm-soc tree.
> 
> Thierry can you give your blessing ?

As Jon mentioned, making support for that EDP IRQ doesn't seem to be the
right thing. If this IRQ does exist on Tegra124/Tegra132, then a more
correct patch would be to add that to the device tree. I vaguely recall
writing a patch to do that, a while back when I was trying to get rid of
a couple of dt_binding_check warnings/errors, so I'll dig around for
that.

I think for now we should probably ignore the driver patch. I'll get
back to you if we determine that EDP IRQ is not present on those SoCs,
in which case the driver patch would be correct.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]