From: Thierry Reding <thierry.reding@gmail.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: jonathanh@nvidia.com, sboyd@kernel.org, mturquette@baylibre.com,
pgaikwad@nvidia.com, pdeschrijver@nvidia.com,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: tegra: Do not return 0 on failure
Date: Fri, 20 Nov 2020 17:16:56 +0100 [thread overview]
Message-ID: <20201120161656.GC3870099@ulmo> (raw)
In-Reply-To: <20201029004820.9062-1-nicoleotsuka@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Wed, Oct 28, 2020 at 05:48:20PM -0700, Nicolin Chen wrote:
> Return values from read_dt_param() will be either TRUE (1) or
> FALSE (0), while dfll_fetch_pwm_params() returns 0 on success
> or an ERR code on failure.
>
> So this patch fixes the bug of returning 0 on failure.
>
> Fixes: 36541f0499fe ("clk: tegra: dfll: support PWM regulator control")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> drivers/clk/tegra/clk-dfll.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Mike, Stephen,
if you don't mind, I'll pick this up in the Tegra tree since there are a
few other Tegra clock patches on the list that may require coordination
inside the Tegra tree.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-20 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 0:48 [PATCH] clk: tegra: Do not return 0 on failure Nicolin Chen
2020-11-20 16:16 ` Thierry Reding [this message]
2020-11-20 16:18 ` Thierry Reding
2020-11-25 2:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120161656.GC3870099@ulmo \
--to=thierry.reding@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicoleotsuka@gmail.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).