linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: tegra: fix emmc on specific bootloaders
@ 2020-11-27 20:01 Peter Geis
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Geis @ 2020-11-27 20:01 UTC (permalink / raw)
  To: Thierry Reding; +Cc: linux-tegra, Peter Geis, Matt Merhar

Ouya fails to detect the emmc module when booting from specific bootloaders.
Fastboot and hard-kexec bootloaders have observed failures while u-boot does not have this issue.
It was discovered that if the sdmmc4 alternate configuration clock pin is input disabled the issue manifests.
Ouya uses sdmmc4 in the primary pin configuration so it is unknown why this occurs.
It is likely related to the other emmc limitations we have on Ouya.

For now, fix it by enabling input on cam_mclk_pcc0.

Fixes: d7195ac5c9c5 ("ARM: tegra: Add device-tree for Ouya")
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Reported-by: Matt Merhar <mattmerhar@protonmail.com>
Tested-by: Matt Merhar <mattmerhar@protonmail.com>
---
 arch/arm/boot/dts/tegra30-ouya.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-ouya.dts b/arch/arm/boot/dts/tegra30-ouya.dts
index 74da1360d297..0368b3b816ef 100644
--- a/arch/arm/boot/dts/tegra30-ouya.dts
+++ b/arch/arm/boot/dts/tegra30-ouya.dts
@@ -4352,8 +4352,8 @@ cam_mclk_pcc0 {
 		nvidia,pins = "cam_mclk_pcc0";
 		nvidia,function = "vi_alt3";
 		nvidia,pull = <TEGRA_PIN_PULL_NONE>;
-		nvidia,tristate = <TEGRA_PIN_ENABLE>;
-		nvidia,enable-input = <TEGRA_PIN_DISABLE>;
+		nvidia,tristate = <TEGRA_PIN_DISABLE>;
+		nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 	};
 	pcc1 {
 		nvidia,pins = "pcc1";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: tegra: fix emmc on specific bootloaders
@ 2020-12-28 14:33 Peter Geis
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Geis @ 2020-12-28 14:33 UTC (permalink / raw)
  To: Rob Herring, Thierry Reding, Jonathan Hunter
  Cc: devicetree, linux-tegra, linux-kernel, Peter Geis, Matt Merhar

Ouya fails to detect the emmc module when booting from specific bootloaders.
Fastboot and hard-kexec bootloaders have observed failures while u-boot does not have this issue.
It was discovered that if the sdmmc4 alternate configuration clock pin is input disabled the issue manifests.
Ouya uses sdmmc4 in the primary pin configuration so it is unknown why this occurs.
It is likely related to the other emmc limitations we have on Ouya.

For now, fix it by enabling input on cam_mclk_pcc0.

Fixes: d7195ac5c9c5 ("ARM: tegra: Add device-tree for Ouya")
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Reported-by: Matt Merhar <mattmerhar@protonmail.com>
Tested-by: Matt Merhar <mattmerhar@protonmail.com>
---
 arch/arm/boot/dts/tegra30-ouya.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra30-ouya.dts b/arch/arm/boot/dts/tegra30-ouya.dts
index 74da1360d297..0368b3b816ef 100644
--- a/arch/arm/boot/dts/tegra30-ouya.dts
+++ b/arch/arm/boot/dts/tegra30-ouya.dts
@@ -4352,8 +4352,8 @@ cam_mclk_pcc0 {
 		nvidia,pins = "cam_mclk_pcc0";
 		nvidia,function = "vi_alt3";
 		nvidia,pull = <TEGRA_PIN_PULL_NONE>;
-		nvidia,tristate = <TEGRA_PIN_ENABLE>;
-		nvidia,enable-input = <TEGRA_PIN_DISABLE>;
+		nvidia,tristate = <TEGRA_PIN_DISABLE>;
+		nvidia,enable-input = <TEGRA_PIN_ENABLE>;
 	};
 	pcc1 {
 		nvidia,pins = "pcc1";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-28 14:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 20:01 [PATCH] ARM: tegra: fix emmc on specific bootloaders Peter Geis
  -- strict thread matches above, loose matches on Subject: below --
2020-12-28 14:33 Peter Geis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).