From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E700C1B0E3 for ; Sat, 5 Dec 2020 18:41:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FB6922EBF for ; Sat, 5 Dec 2020 18:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgLESTV convert rfc822-to-8bit (ORCPT ); Sat, 5 Dec 2020 13:19:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbgLESSU (ORCPT ); Sat, 5 Dec 2020 13:18:20 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C13FC0613D1; Sat, 5 Dec 2020 10:11:09 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id y19so106117lfa.13; Sat, 05 Dec 2020 10:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uKWCtmFWH2D6PgdPDqZ6SwqxYHLfJimrQ5ADIJZYjvM=; b=bXFp09I66lb1RWbMF8/53Taud/7q2BNevsH1z5RzuwlvxP10zIPE3Wyh6joGUrQ5Vu b9wKPDkfrzRe9iw6wtXxw4Bfms40wohZHEHfoDY3SeqnhlhPuperT/DrKyfJ05arZy0R FKQowNsx/wVBNXpUqjsHFssUyFPDZdSdYoPfI6xRFQLkqlJB/PkYsehdRg/D2DdzThR9 I57DXzIOgkeBg+00dbb6jEWD17b5K0cNQGOmQacTylocJvMELGWvW86ZyZDv1IS9jg3l lPnpkG1HS49RcR5wRBGG279jsCr79/ceSGuOiphGjQuDJeLkNWfijgUp56BVDf0rmXd5 OqtQ== X-Gm-Message-State: AOAM530thbLaG2xTk5CGHdJHKeZ1rgNnr7UXUfo5eU0MF15R1pDLemKx Dv3i0eEAhR1qxoLuECp03gF3c6AGQIFZKA== X-Google-Smtp-Source: ABdhPJxIyKieWZJ9VxW5tLvdRrottnwtiJyqsBd6MJRYZ1ZeKbA2NYxoVKNProO+IDV8ruhVa4XFdw== X-Received: by 2002:a17:906:4a47:: with SMTP id a7mr11831799ejv.345.1607176366602; Sat, 05 Dec 2020 05:52:46 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id l19sm5584565edq.14.2020.12.05.05.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Dec 2020 05:52:44 -0800 (PST) Date: Sat, 5 Dec 2020 14:52:42 +0100 From: Krzysztof Kozlowski To: Thierry Reding Cc: Dmitry Osipenko , Jon Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees Message-ID: <20201205135242.GA1978@kozik-lap> References: <20201123002723.28463-1-digetx@gmail.com> <20201123002723.28463-18-digetx@gmail.com> <60657f5e-bd30-094e-f8df-6ba69e0d6a3e@nvidia.com> <1ed05baf-3a01-3a2b-cd79-98b356c846cf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Fri, Dec 04, 2020 at 04:54:55PM +0100, Thierry Reding wrote: > On Tue, Dec 01, 2020 at 01:57:44AM +0300, Dmitry Osipenko wrote: > > 01.12.2020 00:17, Jon Hunter пишет: > > > Hi Dmitry, > > > > > > On 23/11/2020 00:27, Dmitry Osipenko wrote: > > >> Add EMC OPP DVFS tables and update board device-trees by removing > > >> unsupported OPPs. > > >> > > >> Signed-off-by: Dmitry Osipenko > > > This change is generating the following warning on Tegra20 Ventana > > > and prevents the EMC from probing ... > > > > > > [ 2.485711] tegra20-emc 7000f400.memory-controller: device-tree doesn't have memory timings > > > [ 2.499386] tegra20-emc 7000f400.memory-controller: 32bit DRAM bus > > > [ 2.505810] ------------[ cut here ]------------ > > > [ 2.510511] WARNING: CPU: 0 PID: 1 at /local/workdir/tegra/mlt-linux_next/kernel/drivers/opp/of.c:875 _of_add_opp_table_v2+0x598/0x61c > > > [ 2.529746] Modules linked in: > > > [ 2.540140] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.0-rc5-next-20201130 #1 > > > [ 2.554606] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) > > > [ 2.560892] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > > [ 2.568640] [] (show_stack) from [] (dump_stack+0xc8/0xdc) > > > [ 2.575866] [] (dump_stack) from [] (__warn+0x104/0x108) > > > [ 2.582912] [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8) > > > [ 2.590397] [] (warn_slowpath_fmt) from [] (_of_add_opp_table_v2+0x598/0x61c) > > > [ 2.599269] [] (_of_add_opp_table_v2) from [] (dev_pm_opp_of_add_table+0x3c/0x1a0) > > > [ 2.608582] [] (dev_pm_opp_of_add_table) from [] (tegra_emc_probe+0x478/0x940) > > > [ 2.617548] [] (tegra_emc_probe) from [] (platform_drv_probe+0x48/0x98) > > > [ 2.625899] [] (platform_drv_probe) from [] (really_probe+0x218/0x3b8) > > > [ 2.634162] [] (really_probe) from [] (driver_probe_device+0x5c/0xb4) > > > [ 2.642338] [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60) > > > [ 2.651208] [] (device_driver_attach) from [] (__driver_attach+0x80/0xbc) > > > [ 2.659730] [] (__driver_attach) from [] (bus_for_each_dev+0x74/0xb4) > > > [ 2.667905] [] (bus_for_each_dev) from [] (bus_add_driver+0x164/0x1e8) > > > [ 2.676168] [] (bus_add_driver) from [] (driver_register+0x7c/0x114) > > > [ 2.684259] [] (driver_register) from [] (do_one_initcall+0x54/0x2b0) > > > [ 2.692441] [] (do_one_initcall) from [] (kernel_init_freeable+0x1a4/0x1f4) > > > [ 2.701145] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x118) > > > [ 2.709321] [] (kernel_init) from [] (ret_from_fork+0x14/0x24) > > > [ 2.716885] Exception stack(0xc1501fb0 to 0xc1501ff8) > > > [ 2.721933] 1fa0: 00000000 00000000 00000000 00000000 > > > [ 2.730106] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > [ 2.738278] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > [ 2.751940] ---[ end trace 61e3b76deca27ef3 ]--- > > > > > > > > > Cheers > > > Jon > > > > > > > Hello Jon, > > > > That is harmless and expected to happen because the patch "memory: > > tegra20: Support hardware versioning and clean up OPP table > > initialization" isn't applied yet, while Thierry already applied the DT > > patches from this v10. > > Hmm... that's new. Since when are device tree additions expected to > cause these kinds of splats? It looks rather as inaccurate message, but except the message itself, no functionality was lost. > Anyway, I did apply these because I had seen at least some of the memory > controller driver patches appear in linux-next and hence had assumed > that the whole series had gone in, not realizing there was anything left > to do. > > Krzysztof, what's your schedule for the memory controller tree? My > recollection is that this will feed into ARM SoC, so if the -rc6 dead- > line applies like it does for platforms, then I may need to revert the > DT patch that causes this so that we don't have to drag this along > through all of the release cycle. If there's still time for you to send > that PR, perhaps we can get the remainder of the Tegra interconnect > series merged for v5.11 as well? I was waiting for last acks from Rob and you and actually planned to merge everything this week (weekend at the latest). Indeed it slightly slipped away... the v11 was reposted late. It could still make till v5.11, if I send the PR now (still around 3 weeks before merge window). However I saw now your comments for the patch 4/10 from v11. I'll take patches 1-3 for now. Best regards, Krzysztof