From: Mark Brown <broonie@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3] regulator: Make regulator_sync_voltage() usable by coupled regulators
Date: Fri, 22 Jan 2021 13:40:45 +0000 [thread overview]
Message-ID: <20210122134045.GD6391@sirena.org.uk> (raw)
In-Reply-To: <20210121221649.23155-1-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
On Fri, Jan 22, 2021 at 01:16:49AM +0300, Dmitry Osipenko wrote:
> + /* balance only if there are regulators coupled */
> + if (rdev->coupling_desc.n_coupled > 1) {
> + ret = regulator_balance_voltage(rdev, PM_SUSPEND_ON);
> + goto out;
> + }
> +
> ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
>
> out:
This would be clearer written as an if/else rather than using the goto.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-22 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 22:16 [PATCH v3] regulator: Make regulator_sync_voltage() usable by coupled regulators Dmitry Osipenko
2021-01-22 13:40 ` Mark Brown [this message]
2021-01-22 16:00 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122134045.GD6391@sirena.org.uk \
--to=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox