From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-core: Prevent warning if no DMI table is present
Date: Tue, 2 Mar 2021 12:49:13 +0000 [thread overview]
Message-ID: <20210302124913.GC4522@sirena.org.uk> (raw)
In-Reply-To: <20210302092712.310705-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
On Tue, Mar 02, 2021 at 09:27:12AM +0000, Jon Hunter wrote:
> Many systems do not provide a DMI table and on these systems a warning,
> such as the following, is printed on boot ...
>
> WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name!
>
> If DMI support is enabled in the kernel, there is no simple way to
> detect if a DMI table is table or not. Note that the variable
> 'dmi_available' is not exported and so cannot be used by kernel modules.
We could fix that, or provide an accessor function? Or only warn if
we're on an ACPI system (which we can check from a module). This really
does feel like something we should be warning about on systems that are
supposed to have DMI information available as standard.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-03 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:27 [PATCH] ASoC: soc-core: Prevent warning if no DMI table is present Jon Hunter
2021-03-02 12:49 ` Mark Brown [this message]
2021-03-02 17:23 ` Takashi Iwai
2021-03-03 11:50 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302124913.GC4522@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox