From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB4DC433DB for ; Mon, 8 Mar 2021 04:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6214965159 for ; Mon, 8 Mar 2021 04:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232474AbhCHEib (ORCPT ); Sun, 7 Mar 2021 23:38:31 -0500 Received: from foss.arm.com ([217.140.110.172]:59210 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234204AbhCHEiD (ORCPT ); Sun, 7 Mar 2021 23:38:03 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95019D6E; Sun, 7 Mar 2021 20:38:02 -0800 (PST) Received: from bogus (unknown [10.57.15.109]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06E3D3F73C; Sun, 7 Mar 2021 20:37:58 -0800 (PST) Date: Mon, 8 Mar 2021 04:37:55 +0000 From: Sudeep Holla To: Sowjanya Komatineni Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, daniel.lezcano@linaro.org, robh+dt@kernel.org, ksitaraman@nvidia.com, sanjayc@nvidia.com, Sudeep Holla , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v1 3/5] dt-bindings: arm: Add cpu-idle-states to Tegra194 CPU nodes Message-ID: <20210308043755.llvdsuz2jwvweovb@bogus> References: <1614838092-30398-1-git-send-email-skomatineni@nvidia.com> <1614838092-30398-4-git-send-email-skomatineni@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1614838092-30398-4-git-send-email-skomatineni@nvidia.com> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, Mar 03, 2021 at 10:08:10PM -0800, Sowjanya Komatineni wrote: > This patch adds cpu-idle-states and corresponding state nodes to > Tegra194 CPU in dt-binding document > I see that this platform has PSCI support. Can you care to explain why you need additional DT bindings and driver for PSCI based CPU suspend. Until the reasons are convincing, consider NACK from my side for this driver and DT bindings. You should be really using those bindings and the driver may be with minor changes there. -- Regards, Sudeep