From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6277EC433E0 for ; Tue, 16 Mar 2021 21:59:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 308D064F7F for ; Tue, 16 Mar 2021 21:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbhCPV7P (ORCPT ); Tue, 16 Mar 2021 17:59:15 -0400 Received: from elvis.franken.de ([193.175.24.41]:35172 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbhCPV7D (ORCPT ); Tue, 16 Mar 2021 17:59:03 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lMHiN-00059F-00; Tue, 16 Mar 2021 22:58:59 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id EA85BC08CC; Tue, 16 Mar 2021 22:58:20 +0100 (CET) Date: Tue, 16 Mar 2021 22:58:20 +0100 From: Thomas Bogendoerfer To: Krzysztof Kozlowski Cc: John Crispin , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, balbi@kernel.org, linux-usb@vger.kernel.org, digetx@gmail.com, kernel test robot Subject: Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing Message-ID: <20210316215820.GA18064@alpha.franken.de> References: <20210316175725.79981-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316175725.79981-1-krzysztof.kozlowski@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Mar 16, 2021 at 06:57:25PM +0100, Krzysztof Kozlowski wrote: > The Ralink MIPS platform does not use Common Clock Framework and does > not define certain clock operations leading to compile test failures: > > /usr/bin/mips-linux-gnu-ld: drivers/usb/phy/phy-tegra-usb.o: in function `tegra_usb_phy_init': > phy-tegra-usb.c:(.text+0x1dd4): undefined reference to `clk_get_parent' hmm, why not make it use common clock framework ? And shouldn't include/linux/clk.h provide what you need, if CONFIG_HAVE_CLK is not set ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]