From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1739C433E1 for ; Sat, 20 Mar 2021 15:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEF736196A for ; Sat, 20 Mar 2021 15:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhCTP2a (ORCPT ); Sat, 20 Mar 2021 11:28:30 -0400 Received: from netrider.rowland.org ([192.131.102.5]:42727 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S229756AbhCTP2I (ORCPT ); Sat, 20 Mar 2021 11:28:08 -0400 Received: (qmail 608526 invoked by uid 1000); 20 Mar 2021 11:28:07 -0400 Date: Sat, 20 Mar 2021 11:28:07 -0400 From: Alan Stern To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Peter Chen , Greg Kroah-Hartman , Felipe Balbi , Arnd Bergmann , linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] usb: host: ehci-tegra: Select USB_GADGET Kconfig option Message-ID: <20210320152807.GA606911@rowland.harvard.edu> References: <20210320151915.7566-1-digetx@gmail.com> <20210320151915.7566-2-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320151915.7566-2-digetx@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Sat, Mar 20, 2021 at 06:19:15PM +0300, Dmitry Osipenko wrote: > Select USB_GADGET Kconfig option in order to fix build failure which > happens because ChipIdea driver has a build dependency on both USB_GADGET > and USB_EHCI_HCD, while USB_EHCI_TEGRA force-selects the ChipIdea driver > without taking into account the tristate USB_GADGET dependency. It's not > possible to do anything about the cyclic dependency of the Kconfig > options, but USB_EHCI_TEGRA is now a deprecated option that isn't used > by defconfigs and USB_GADGET is wanted on Tegra by default, hence it's > okay to have a bit clunky workaround for it. > > Fixes: c3590c7656fb ("usb: host: ehci-tegra: Remove the driver") > Reported-by: kernel test robot > Signed-off-by: Dmitry Osipenko Acked-by: Alan Stern > --- > drivers/usb/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index b94f2a070c05..df9428f1dc5e 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -272,6 +272,7 @@ config USB_EHCI_TEGRA > select USB_CHIPIDEA > select USB_CHIPIDEA_HOST > select USB_CHIPIDEA_TEGRA > + select USB_GADGET > help > This option is deprecated now and the driver was removed, use > USB_CHIPIDEA_TEGRA instead. > -- > 2.30.2 >