* [PATCH] clk: tegra: fix old-style declaration
@ 2021-03-22 21:50 Arnd Bergmann
2021-03-23 8:24 ` Thierry Reding
2021-08-29 18:38 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-03-22 21:50 UTC (permalink / raw)
To: Peter De Schrijver, Prashant Gaikwad, Michael Turquette,
Stephen Boyd, Thierry Reding, Jonathan Hunter
Cc: Arnd Bergmann, Nicolin Chen, linux-clk, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
With extra warnings enabled, gcc complains about a slightly odd
prototype:
drivers/clk/tegra/clk-dfll.c:1380:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
1380 | static void inline dfll_debug_init(struct tegra_dfll *td) { }
Move the 'inline' keyword to the start of the line.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/tegra/clk-dfll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
index a5f526bb0483..6144447f86c6 100644
--- a/drivers/clk/tegra/clk-dfll.c
+++ b/drivers/clk/tegra/clk-dfll.c
@@ -1377,7 +1377,7 @@ static void dfll_debug_init(struct tegra_dfll *td)
}
#else
-static void inline dfll_debug_init(struct tegra_dfll *td) { }
+static inline void dfll_debug_init(struct tegra_dfll *td) { }
#endif /* CONFIG_DEBUG_FS */
/*
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk: tegra: fix old-style declaration
2021-03-22 21:50 [PATCH] clk: tegra: fix old-style declaration Arnd Bergmann
@ 2021-03-23 8:24 ` Thierry Reding
2021-08-29 18:38 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-03-23 8:24 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Peter De Schrijver, Prashant Gaikwad, Michael Turquette,
Stephen Boyd, Jonathan Hunter, Arnd Bergmann, Nicolin Chen,
linux-clk, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Mon, Mar 22, 2021 at 10:50:41PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With extra warnings enabled, gcc complains about a slightly odd
> prototype:
>
> drivers/clk/tegra/clk-dfll.c:1380:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
> 1380 | static void inline dfll_debug_init(struct tegra_dfll *td) { }
>
> Move the 'inline' keyword to the start of the line.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/clk/tegra/clk-dfll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: tegra: fix old-style declaration
2021-03-22 21:50 [PATCH] clk: tegra: fix old-style declaration Arnd Bergmann
2021-03-23 8:24 ` Thierry Reding
@ 2021-08-29 18:38 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-08-29 18:38 UTC (permalink / raw)
To: Arnd Bergmann, Jonathan Hunter, Michael Turquette,
Peter De Schrijver, Prashant Gaikwad, Thierry Reding
Cc: Arnd Bergmann, Nicolin Chen, linux-clk, linux-tegra, linux-kernel
Quoting Arnd Bergmann (2021-03-22 14:50:41)
> From: Arnd Bergmann <arnd@arndb.de>
>
> With extra warnings enabled, gcc complains about a slightly odd
> prototype:
>
> drivers/clk/tegra/clk-dfll.c:1380:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
> 1380 | static void inline dfll_debug_init(struct tegra_dfll *td) { }
>
> Move the 'inline' keyword to the start of the line.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-29 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22 21:50 [PATCH] clk: tegra: fix old-style declaration Arnd Bergmann
2021-03-23 8:24 ` Thierry Reding
2021-08-29 18:38 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox