From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <maz@kernel.org>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt
Date: Tue, 20 Apr 2021 14:14:28 +0100 [thread overview]
Message-ID: <20210420131428.GA5734@lpieralisi> (raw)
In-Reply-To: <20210420125545.1315970-1-jonathanh@nvidia.com>
On Tue, Apr 20, 2021 at 01:55:45PM +0100, Jon Hunter wrote:
> Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the
> Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This
> is breaking a PCIe sanity test that we are running on Tegra124 Jetson
> TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which
> is no longer found. Although we could update the test to fix this, at
> the same time it does not seem necessary to rename the interrupt.
> Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.
>
> Fixes: 973a28677e39 ("PCI: tegra: Convert to MSI domains")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/pci/controller/pci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Squashed with the Fixes: commit in my pci/msi branch, pushed out.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index eaba7b2fab4a..32ca16c87092 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
> }
>
> static struct irq_chip tegra_msi_top_chip = {
> - .name = "tegra PCIe MSI",
> + .name = "Tegra PCIe MSI",
> .irq_ack = tegra_msi_top_irq_ack,
> .irq_mask = tegra_msi_top_irq_mask,
> .irq_unmask = tegra_msi_top_irq_unmask,
> --
> 2.25.1
>
prev parent reply other threads:[~2021-04-20 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 12:55 [PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt Jon Hunter
2021-04-20 13:04 ` Marc Zyngier
2021-04-20 13:14 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420131428.GA5734@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maz@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox