From: "Krzysztof Wilczyński" <kw@linux.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: p.zabel@pengutronix.de, linux-pci@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag
Date: Thu, 13 May 2021 14:23:57 +0200 [thread overview]
Message-ID: <20210513122357.GA202784@rocinante.localdomain> (raw)
In-Reply-To: <1620907394-55649-1-git-send-email-tiantao6@hisilicon.com>
Hi Tian,
Thank you for sending the patch over!
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
A few comments.
The commit message is a bit terse and the subject could be improved
a little. Does this change fixes an issue with the driver? Why is this
flag needed? The commit message could explain better why this change is
needed, etc.
Krzysztof
prev parent reply other threads:[~2021-05-13 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 12:03 [PATCH] PCI: tegra: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-05-13 12:23 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513122357.GA202784@rocinante.localdomain \
--to=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox