From: Jon Hunter <jonathanh@nvidia.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
Vidya Sagar <vidyas@nvidia.com>
Cc: <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH] PCI: tegra: Fix shiftTooManyBitsSigned warning for Tegra194
Date: Fri, 18 Jun 2021 17:02:19 +0100 [thread overview]
Message-ID: <20210618160219.303092-1-jonathanh@nvidia.com> (raw)
The cppcheck tool issues the following warning for the Tegra194 PCIe
driver ...
$ cppcheck --enable=all drivers/pci/controller/dwc/pcie-tegra194.c
Checking drivers/pci/controller/dwc/pcie-tegra194.c ...
drivers/pci/controller/dwc/pcie-tegra194.c:1829:23: portability:
Shifting signed 32-bit value by 31 bits is
implementation-defined behaviour. See condition at line 1826.
[shiftTooManyBitsSigned]
appl_writel(pcie, (1 << irq), APPL_MSI_CTRL_1);
^
The above warning occurs because the '1' is treated as a signed type
and so fix this by using the 'BIT' macro to ensure that this is defined
as a unsigned type.
Fixes: c57247f940e8 PCI: tegra: Add support for PCIe endpoint mode in Tegra194
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 8fc08336f76e..3c1feeab104f 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -1826,7 +1826,7 @@ static int tegra_pcie_ep_raise_msi_irq(struct tegra_pcie_dw *pcie, u16 irq)
if (unlikely(irq > 31))
return -EINVAL;
- appl_writel(pcie, (1 << irq), APPL_MSI_CTRL_1);
+ appl_writel(pcie, BIT(irq), APPL_MSI_CTRL_1);
return 0;
}
--
2.25.1
next reply other threads:[~2021-06-18 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 16:02 Jon Hunter [this message]
2021-06-18 16:05 ` [PATCH] PCI: tegra: Fix shiftTooManyBitsSigned warning for Tegra194 Jon Hunter
2021-06-18 23:04 ` Bjorn Helgaas
2021-06-23 8:52 ` Lorenzo Pieralisi
2021-06-23 12:04 ` Bjorn Helgaas
2021-06-24 23:01 ` Bjorn Helgaas
2021-06-25 9:08 ` Lorenzo Pieralisi
2021-06-23 15:23 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618160219.303092-1-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox