[PATCH] ARM: tegra: Add compatible string for built-in ASIX on Colibri boards

[PATCH] ARM: tegra: Add compatible string for built-in ASIX on Colibri boards

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

The device tree node for the built-in ASIX Ethernet device on Colibri
boards needs a compatible string in order to pass DT schema validation.
Add the USB VID,PID compatible string as required by the DT schema for
USB devices.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Marcel, Philippe, I've used the USB vendor and device IDs from the ASIX
driver match entry for the AX88772B module, but do you have a quick way
of verifying that that's indeed the ID that the device reports in those
systems?

Rob, I do get a checkpatch.pl warning for this new compatible string,
but I'm not sure there's anything easy that could be done about this,
other than perhaps making checkpatch.pl aware of the special USB (and
potentially PCI) compatible strings as well.
---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 1 +
 arch/arm/boot/dts/tegra30-colibri.dtsi | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/tegra20-colibri.dtsi b/arch/arm/boot/dts/tegra20-colibri.dtsi
index 2350fda3be6a..c5c401edd0bf 100644
--- a/arch/arm/boot/dts/tegra20-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri.dtsi
@@ -689,6 +689,7 @@ usb@c5004000 {
 		#size-cells = <0>;
 
 		asix@1 {
+			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
 		};
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index e89b4e5a238d..4361b93d0934 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -950,6 +950,7 @@ usb@7d004000 {
 		#size-cells = <0>;
 
 		asix@1 {
+			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
 		};
-- 
2.33.1

Re: [PATCH] ARM: tegra: Add compatible string for built-in ASIX on Colibri boards

[Marcel Ziswiler]

On Tue, 2021-12-07 at 13:56 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The device tree node for the built-in ASIX Ethernet device on Colibri
> boards needs a compatible string in order to pass DT schema validation.
> Add the USB VID,PID compatible string as required by the DT schema for
> USB devices.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
> Marcel, Philippe, I've used the USB vendor and device IDs from the ASIX
> driver match entry for the AX88772B module, but do you have a quick way
> of verifying that that's indeed the ID that the device reports in those
> systems?

Yes, that looks fine:

root@colibri-t30:~# uname -a
Linux colibri-t30 5.16.0-rc4-next-20211207-00025-g122da7b0a9d4 #2 SMP PREEMPT Tue Dec 7 16:54:46 CET 2021
armv7l GNU/Linux
root@colibri-t30:~# lsusb
Bus 003 Device 002: ID 0424:2514 Standard Microsystems Corp. USB 2.0 Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 002: ID 0b95:772b ASIX Electronics Corp. AX88772B
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

Thanks, Thierry!

> Rob, I do get a checkpatch.pl warning for this new compatible string,
> but I'm not sure there's anything easy that could be done about this,
> other than perhaps making checkpatch.pl aware of the special USB (and
> potentially PCI) compatible strings as well.
> ---
>  arch/arm/boot/dts/tegra20-colibri.dtsi | 1 +
>  arch/arm/boot/dts/tegra30-colibri.dtsi | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/tegra20-colibri.dtsi b/arch/arm/boot/dts/tegra20-colibri.dtsi
> index 2350fda3be6a..c5c401edd0bf 100644
> --- a/arch/arm/boot/dts/tegra20-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra20-colibri.dtsi
> @@ -689,6 +689,7 @@ usb@c5004000 {
>                 #size-cells = <0>;
>  
>                 asix@1 {
> +                       compatible = "usbb95,772b";
>                         reg = <1>;
>                         local-mac-address = [00 00 00 00 00 00];
>                 };
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index e89b4e5a238d..4361b93d0934 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -950,6 +950,7 @@ usb@7d004000 {
>                 #size-cells = <0>;
>  
>                 asix@1 {
> +                       compatible = "usbb95,772b";
>                         reg = <1>;
>                         local-mac-address = [00 00 00 00 00 00];
>                 };