Re: [PATCH v5 06/24] ARM: tegra: Add common device-tree base for Tegra30 ASUS Transformers

Thierry Reding
2021-12-10T15:50:40Z

[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]

On Wed, Dec 08, 2021 at 08:35:51PM +0300, Dmitry Osipenko wrote:
> From: Svyatoslav Ryhel <clamor95@gmail.com>
>
> Add common DTSI for Tegra30 ASUS Transformers. It will be used by multiple
> device-trees of ASUS devices. The common part initially was born out of
> the ASUS TF300T tablet's device-tree that was created by Michał Mirosław.
> It was heavily reworked and improved by Svyatoslav Ryhel, Maxim Schwalm,
> Ion Agorria et al.
>
> [digetx@gmail.com: factored out common part into separate patch and wrote commit message]
> Co-developed-by: Ion Agorria <ion@agorria.com>
> Signed-off-by: Ion Agorria <ion@agorria.com>
> Co-developed-by: Maxim Schwalm <maxim.schwalm@gmail.com>
> Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com>
> Co-developed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../dts/tegra30-asus-transformer-common.dtsi | 1729 +++++++++++++++++
> 1 file changed, 1729 insertions(+)
> create mode 100644 arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
>
> diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> new file mode 100644
> index 000000000000..be77212dd8c7
> --- /dev/null
> +++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
> @@ -0,0 +1,1729 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <dt-bindings/input/gpio-keys.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/thermal/thermal.h>
> +
> +#include "tegra30.dtsi"
> +#include "tegra30-cpu-opp.dtsi"
> +#include "tegra30-cpu-opp-microvolt.dtsi"
> +
> +/ {
> + chassis-type = "convertible";
> +
> + aliases {
> + mmc0 = &sdmmc4; /* eMMC */

Looks like a tab snuck in there... otherwise this also has some nodes
sorted in the wrong order.

[...]
> + pad-keys {

Any specific reason why this is called pad-keys? We call it gpio-keys
everywhere else.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]