From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98354C433F5 for ; Wed, 8 Dec 2021 20:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236943AbhLHVCh (ORCPT ); Wed, 8 Dec 2021 16:02:37 -0500 Received: from mail-bn8nam08on2072.outbound.protection.outlook.com ([40.107.100.72]:41665 "EHLO NAM04-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236037AbhLHVCg (ORCPT ); Wed, 8 Dec 2021 16:02:36 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UvJTeM/qEJqUHnJi4kmlsshLyjhxlX9eOqfKfNsMyaAQzqQ6OYFY9Ef9XHuOQGvQYalR4I9L0zzj8x4QN2PN8K8yP6cWEDZagY2kJOyhOEyUKQkQaRxajsIYnHC0mdP3ijOq6z08CuDF8DYqj+17lydTM0Er2qjkafFHriM3YRMJeLBaE62PnhWaMiRQAFf1B5CoVRIslXj/je+1gaTu/ZuH/K3ZOHeCfUI2xCw0MTH1ngH2Q6lnySe4bIHHKyf7ustN4aHX59ORID05ZoOR56m3pYlTVcYX5QnKmrLha9K5KQ2NSJkLDLw0GNWAy2Zr7LhXm75WjAUT9Zi8N96XcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mfzE93B1XQO5sUE7mcQ9XWGBnUEc1oIR5TGlenpC6xY=; b=LRC5c5qGb8XBNZX4dcYNxeaPEKT41j3+O/RZrLgqCNXvdUwmzwk4LBxmfqScBfW2NzbvbR5ev+7WY/pS4dcsgwzi61cMQHP4NjDWm9RLRD8AqcPWMDK3riPxxnZJ5M9/NQ+mTwX0t02JQA1juqRfmsAQjyOxL+bRhj+/8LNmWmtOC3Ny6pLJ06HetgltQRt4EH79ucBVlMyASuncUIh/zE9dccHeR3w/2CggdhmH99rel8i2gq/Ft3j8xeagrioF9tEmjWZJl8sWryI7fEC4iktgAl00ldcH7Lshn40vIdQe616hVsom26GrT/V1ZpvS4v+toRKBSyEAiuDo+Os49g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 203.18.50.13) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mfzE93B1XQO5sUE7mcQ9XWGBnUEc1oIR5TGlenpC6xY=; b=KYabe7EjyUzkFRVTMTqMSexwIJIpUbxEiQp1ZhP/9xfPdSqeDY68hmzspBqgkB9JGguYUpPr3bFLNdfXXgK3m0NfCNLA64NEZ3521RnZLiQd2P9u8EtK+vIk+vGTM9DvO7K/8dtsdg4ePTGbNiDmUOI3kC/xNSWfX+iDJnL1noM8dpQJfVkpkKy8KGNHjXOVx/79tlhvmimHhx2X+6HrM/68KM2F5WpAyAbyTQPTPkagii00JqfXVXCYsueaR5hlvlLq7MIpXvU7A+pZHTg+KG2ERAiXtvY2aPn9omQT7yWHwi+Wrzc/rmOnOyV2fIgOPlA8wRiLgNAJFJ34TzEh5A== Received: from BN9PR03CA0088.namprd03.prod.outlook.com (2603:10b6:408:fc::33) by PH0PR12MB5419.namprd12.prod.outlook.com (2603:10b6:510:e9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Wed, 8 Dec 2021 20:59:01 +0000 Received: from BN8NAM11FT021.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fc:cafe::63) by BN9PR03CA0088.outlook.office365.com (2603:10b6:408:fc::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21 via Frontend Transport; Wed, 8 Dec 2021 20:59:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 203.18.50.13) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 203.18.50.13 as permitted sender) receiver=protection.outlook.com; client-ip=203.18.50.13; helo=mail.nvidia.com; Received: from mail.nvidia.com (203.18.50.13) by BN8NAM11FT021.mail.protection.outlook.com (10.13.177.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4755.13 via Frontend Transport; Wed, 8 Dec 2021 20:59:00 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 8 Dec 2021 20:58:57 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 8 Dec 2021 12:58:55 -0800 Received: from Asurada-Nvidia (172.20.187.5) by mail.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Wed, 8 Dec 2021 12:58:55 -0800 Date: Wed, 8 Dec 2021 12:58:54 -0800 From: Nicolin Chen To: Dmitry Osipenko CC: , , , , , , , Subject: Re: [PATCH v7 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Message-ID: <20211208205853.GA25739@Asurada-Nvidia> References: <20211208084732.23363-1-nicolinc@nvidia.com> <20211208084732.23363-7-nicolinc@nvidia.com> <090bcb4e-ae22-bdcd-2837-e1afc3317cb6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <090bcb4e-ae22-bdcd-2837-e1afc3317cb6@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71d95bca-f166-4fb1-ec0c-08d9ba8d8f87 X-MS-TrafficTypeDiagnostic: PH0PR12MB5419:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dodme6FiiV8jFX1KVsrJLj5slDKvAwW4DumkkLIiv1mkYVkqBjRD93fJtC1wj483EBaEN4lrwadRIjBSkVA8a8diJVqOCtv1F8uEtHiWnFqgmOY5Fl8/aE5uPM2MdEv3Lz/aE2+CeC8mDs2wvfBI0tCGgLE/IOs2ywp49cVhWz882jFFqETuEZKm/veOW+jK6413XeI2jWU7MMvzNFRr3HNn8vXzR13Pvj7G4sKkCKMGw/p21Nrh84+RcdpqwkrPSxownZ5Ps+4/ai92Z+PqUaz9uXW9Hhde08+fA4pwX2bLYZstmKiqfaVNqUJ6+uB4qlsXU8hqiWJJ3pJg+2k7HAoRh9cY5xOtPgQCx9jnXBKaiaUn6lDIt2ONAmy4I8GRZPHrqLbJMdUGPfQni0ZI8I4M9HIanuhYwjZWkN2kNsGVCJN+zXufz0pX+2pbcHihZGX5jHMNOwq6HyWIhLdU/8pEeynbKybTwuAfin5opbPJQOFtwrETjpCTRG/U/5iDCcrFriwZHv66bBcdUedDVhabFM3w8r+DSWSbT159nZ9dv1a35ELc7ud7vocYF0gE8pt4phBOzM5AOkw3YgCAl/dYxJAloFVvozflsZUuIQUXGps68yt13lwNUyrRorfLUjVZKYmtAtDG3MVhRDymi3sq9PuUMtMSYFXN59g1JEVgPa+kdXce55ydl7Kjk1HfB4x3ZNEoTk7H0RsS9DNU+4P3MddzLMtRw392Ewwo7ji96ucHKYSkdiH4NdooWEDsrqmPXoVNTRqOmOWCh2puF8v2ibIWmHhlvsTQuSYx6bQ= X-Forefront-Antispam-Report: CIP:203.18.50.13;CTRY:HK;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:hkhybrid02.nvidia.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(83380400001)(4326008)(5660300002)(70206006)(70586007)(6916009)(8676002)(33656002)(7636003)(2906002)(54906003)(9686003)(47076005)(86362001)(186003)(40460700001)(426003)(356005)(316002)(34070700002)(82310400004)(1076003)(508600001)(336012)(55016003)(26005)(8936002)(36860700001)(33716001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 20:59:00.5997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71d95bca-f166-4fb1-ec0c-08d9ba8d8f87 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[203.18.50.13];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT021.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5419 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, Dec 08, 2021 at 07:09:37PM +0300, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 08.12.2021 11:47, Nicolin Chen пишет: > > static void tegra_smmu_attach_as(struct tegra_smmu *smmu, > > struct tegra_smmu_as *as, > > unsigned int swgroup) > > @@ -517,6 +646,12 @@ static void tegra_smmu_attach_as(struct tegra_smmu *smmu, > > dev_warn(smmu->dev, > > "overwriting group->as for swgroup: %s\n", swgrp->name); > > group->as = as; > > + > > + if (smmu->debugfs_mappings) > > + debugfs_create_file(group->swgrp->name, 0444, > > + smmu->debugfs_mappings, group, > > + &tegra_smmu_debugfs_mappings_fops); > > I noticed this in KMSG: > > tegra-mc 7000f000.memory-controller: overwriting group->as for swgroup: g2 > debugfs: File 'g2' in directory 'mappings' already present! > tegra-mc 7000f000.memory-controller: overwriting group->as for swgroup: g2 > debugfs: File 'g2' in directory 'mappings' already present > > Doesn't look okay, please fix. Thanks for testing and reporting! I will see and fix it along with your other comments.