From: Nicolin Chen <nicolinc@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: <thierry.reding@gmail.com>, <joro@8bytes.org>, <will@kernel.org>,
<vdumpa@nvidia.com>, <jonathanh@nvidia.com>,
<linux-tegra@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs
Date: Thu, 9 Dec 2021 11:24:51 -0800 [thread overview]
Message-ID: <20211209192450.GA34762@Asurada-Nvidia> (raw)
In-Reply-To: <63b4c2e2-0e55-5701-4c45-70684c7e058e@gmail.com>
On Thu, Dec 09, 2021 at 05:49:09PM +0300, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 09.12.2021 10:38, Nicolin Chen пишет:
> > +static unsigned long pd_pt_index_iova(unsigned int pd_index, unsigned int pt_index)
> > +{
> > + return (pd_index & (SMMU_NUM_PDE - 1)) << SMMU_PDE_SHIFT |
> > + (pt_index & (SMMU_NUM_PTE - 1)) << SMMU_PTE_SHIFT;
> > +}
>
> I'd change the return type to u32 here, for consistency.
The whole file defines iova using "unsigned long", which I see
as the consistency... If we change it to u32, it'd be probably
necessary to change all iova types to u32 too... So I'd rather
keep it "unsigned long" here. If you see a big necessity to do
that, an additional patch would be nicer IMHO.
next prev parent reply other threads:[~2021-12-09 19:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 7:38 [PATCH v8 0/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-12-09 7:38 ` [PATCH v8 1/6] iommu/tegra-smmu: Rename struct iommu_group *group to *grp Nicolin Chen
2021-12-09 7:38 ` [PATCH v8 2/6] iommu/tegra-smmu: Rename tegra_smmu_find_group to tegra_smmu_find_group_soc Nicolin Chen
2021-12-09 7:38 ` [PATCH v8 3/6] iommu/tegra-smmu: Rename struct tegra_smmu_swgroup *group to *swgrp Nicolin Chen
2021-12-09 7:38 ` [PATCH v8 4/6] iommu/tegra-smmu: Use swgrp pointer instead of swgroup id Nicolin Chen
2021-12-09 7:38 ` [PATCH v8 5/6] iommu/tegra-smmu: Attach as pointer to tegra_smmu_group Nicolin Chen
2021-12-09 7:38 ` [PATCH v8 6/6] iommu/tegra-smmu: Add pagetable mappings to debugfs Nicolin Chen
2021-12-09 14:47 ` Dmitry Osipenko
2021-12-09 19:32 ` Nicolin Chen
2021-12-09 19:40 ` Dmitry Osipenko
2021-12-09 19:51 ` Nicolin Chen
2021-12-09 19:58 ` Dmitry Osipenko
2021-12-09 20:06 ` Nicolin Chen
2021-12-09 14:49 ` Dmitry Osipenko
2021-12-09 19:24 ` Nicolin Chen [this message]
2021-12-09 19:44 ` Dmitry Osipenko
2021-12-09 19:54 ` Nicolin Chen
2021-12-09 19:58 ` Dmitry Osipenko
2021-12-09 20:01 ` Nicolin Chen
2021-12-09 20:03 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209192450.GA34762@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=digetx@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox