From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0A7C433F5 for ; Wed, 16 Feb 2022 07:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbiBPHR0 (ORCPT ); Wed, 16 Feb 2022 02:17:26 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:34294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiBPHRY (ORCPT ); Wed, 16 Feb 2022 02:17:24 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3590A286C1 for ; Tue, 15 Feb 2022 23:17:10 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKEYJ-0007Pg-NX; Wed, 16 Feb 2022 08:16:39 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nKEYE-0000vr-0Z; Wed, 16 Feb 2022 08:16:34 +0100 Date: Wed, 16 Feb 2022 08:16:33 +0100 From: Oleksij Rempel To: Florian Fainelli Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , "David S. Miller" , Jakub Kicinski , Krzysztof Kozlowski , Nicolas Saenz Julienne , Ray Jui , Rob Herring , Sascha Hauer , Scott Branden , Shawn Guo , Tony Lindgren , kernel@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v3 4/8] ARM: dts: bcm283x: fix ethernet node name Message-ID: <20220216071633.GB19299@pengutronix.de> References: <20220215080937.2263111-1-o.rempel@pengutronix.de> <20220215080937.2263111-4-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:10:05 up 67 days, 15:55, 56 users, load average: 0.27, 0.23, 0.18 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-tegra@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Feb 15, 2022 at 01:01:06PM -0800, Florian Fainelli wrote: > On 2/15/22 12:09 AM, Oleksij Rempel wrote: > > It should be "ethernet@x" instead of "usbether@x" > > > > Signed-off-by: Oleksij Rempel > > This looks like, a quick grep on the u-boot source code seems to suggest > that only one file is assuming that 'usbether@1' is to be used as a node > name and the error message does not even match the code it is patching: > > board/liebherr/xea/xea.c: > #ifdef CONFIG_OF_BOARD_SETUP > static int fdt_fixup_l2switch(void *blob) > { > u8 ethaddr[6]; > int ret; > > if (eth_env_get_enetaddr("ethaddr", ethaddr)) { > ret = fdt_find_and_setprop(blob, > > "/ahb@80080000/switch@800f0000", > "local-mac-address", > ethaddr, 6, 1); > if (ret < 0) > printf("%s: can't find usbether@1 node: %d\n", > __func__, ret); > } \o/ :) > return 0; > } > > I will wait for the other maintainers on the other patches to provide > some feedback, but if all is well, will apply this one soon. Full path fdt matching has proven to be not stable enough. Especially on chips with early DT adaptation like iMX. It is better to use aliases where possible. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |