Re: [Patch v5 2/4] memory: tegra: Add MC error logging on tegra186 onward

Ashish Mhetre
2022-03-22T17:23:44Z

On 3/19/2022 9:29 PM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 16.03.2022 12:25, Ashish Mhetre пишет:
>> diff --git a/include/soc/tegra/mc.h b/include/soc/tegra/mc.h
>> index 92f810c55b43..6f115436e344 100644
>> --- a/include/soc/tegra/mc.h
>> +++ b/include/soc/tegra/mc.h
>> @@ -203,6 +203,8 @@ struct tegra_mc_soc {
>> const struct tegra_smmu_soc *smmu;
>>
>> u32 intmask;
>> + u32 int_channel_mask;
>
> ch_intmask
>
Okay, I will update,

>> + bool has_addr_hi_reg;
>>
>> const struct tegra_mc_reset_ops *reset_ops;
>> const struct tegra_mc_reset *resets;
>> @@ -210,6 +212,8 @@ struct tegra_mc_soc {
>>
>> const struct tegra_mc_icc_ops *icc_ops;
>> const struct tegra_mc_ops *ops;
>> +
>> + int (*get_int_channel)(const struct tegra_mc *mc, int *mc_channel);
>
> This should be a part of tegra_mc_ops.

tegra_mc_ops is common for T186, T194 and T234 i.e. all of them use
tegra186_mc_ops. get_int_channel function has to be differently
implemented for all of these SOCs. So I had put it in tegra_mc_soc.