* [PATCH] clk: tegra: Fix refcount leak in tegra114_clock_init
@ 2022-05-23 14:38 Miaoqian Lin
2022-08-23 2:05 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-23 14:38 UTC (permalink / raw)
To: Peter De Schrijver, Prashant Gaikwad, Michael Turquette,
Stephen Boyd, Thierry Reding, Jonathan Hunter, Stephen Warren,
Mike Turquette, linux-clk, linux-tegra, linux-kernel
Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 2cb5efefd6f7 ("clk: tegra: Implement clocks for Tegra114")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/clk/tegra/clk-tegra114.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
index ef718c4b3826..f7405a58877e 100644
--- a/drivers/clk/tegra/clk-tegra114.c
+++ b/drivers/clk/tegra/clk-tegra114.c
@@ -1317,6 +1317,7 @@ static void __init tegra114_clock_init(struct device_node *np)
}
pmc_base = of_iomap(node, 0);
+ of_node_put(node);
if (!pmc_base) {
pr_err("Can't map pmc registers\n");
WARN_ON(1);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clk: tegra: Fix refcount leak in tegra114_clock_init
2022-05-23 14:38 [PATCH] clk: tegra: Fix refcount leak in tegra114_clock_init Miaoqian Lin
@ 2022-08-23 2:05 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2022-08-23 2:05 UTC (permalink / raw)
To: Jonathan Hunter, Miaoqian Lin, Michael Turquette, Mike Turquette,
Peter De Schrijver, Prashant Gaikwad, Stephen Warren,
Thierry Reding, linux-clk, linux-kernel, linux-tegra
Cc: linmq006
Quoting Miaoqian Lin (2022-05-23 07:38:34)
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 2cb5efefd6f7 ("clk: tegra: Implement clocks for Tegra114")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-23 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-23 14:38 [PATCH] clk: tegra: Fix refcount leak in tegra114_clock_init Miaoqian Lin
2022-08-23 2:05 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).