From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C937EC433EF for ; Mon, 6 Jun 2022 13:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238432AbiFFNS4 (ORCPT ); Mon, 6 Jun 2022 09:18:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238428AbiFFNSz (ORCPT ); Mon, 6 Jun 2022 09:18:55 -0400 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B5F215242D for ; Mon, 6 Jun 2022 06:18:50 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 43D8924000A; Mon, 6 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654521528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQMnz3kE25tuaHePTw9IIcU1s7DFhes1/13W4tlWP0g=; b=Q5TqKuS6rm5fKUbW/to2iIks63dYveytMItZN2hQSGiABR1yQZaWIH2Wv3feBM+l71PDhZ 7hym5Z3FW0h+npJn81HTjHLseNMoNrZ0oZ/kspCkbk5Ka7N0ZwnLqP4EYcgXTtQ3/L9X4N zdw6nHv4EtsheM4g0P3UtTdddQD0ITB2W3HM+r4MZNQ/1tuLq5GIG8pvs8TMps7AAAWvDq KWEheiUzVKJwXJ40gpKBdibyxlFHBpB7P1POSyqkmc9F4g26Gm1ZcN7V/ikAnPNjpsZEC8 r6WqDp2Hd1vqY4u3kJfrLvtgLCgxjfK9U+wbX7n6tDiG5WHcgk0IWvmrDbijNA== Date: Mon, 6 Jun 2022 15:18:41 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Vignesh Raghavendra , Richard Weinberger , Tudor Ambarus , Pratyush Yadav , Joel Stanley , Michael Ellerman , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Liang Yang , Neil Armstrong , Kevin Hilman , kernel@pengutronix.de, linux-mtd@lists.infradead.org, Michael Walle , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-tegra@vger.kernel.org, Jerome Brunet , Martin Blumenstingl , linux-amlogic@lists.infradead.org Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Message-ID: <20220606151841.682a5939@xps-13> In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> References: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Folks, u.kleine-koenig@pengutronix.de wrote on Fri, 3 Jun 2022 23:07:44 +0200: > Hello, >=20 > this series prepares to make platform remove callbacks return void. > Therefor first update them to always return 0. The rationale is that the > Linux device model doesn't handle failures on remove and if a remove > callback returns an error, it just emits a quite generic error message > and still removes the device. Tudor, Pratyush, Richard, Vignesh, The series looks good to me (besides the atmel patch), I think it's best to take it directly through mtd/next instead of going through all the different internal branches, please let me know if you disagree with the idea. Cheers, Miqu=C3=A8l >=20 > Best regards > Uwe >=20 > Uwe Kleine-K=C3=B6nig (14): > mtd: hyperbus: Make hyperbus_unregister_device() return void > mtd: spi-nor: aspeed-smc: Make aspeed_smc_unregister() return void > mtd: powernv_flash: Warn about failure to unregister mtd device > mtd: st-spi_fsm: Warn about failure to unregister mtd device > mtd: lpddr2_nvm: Warn about failure to unregister mtd device > mtd: spear_smi: Don't skip cleanup after mtd_device_unregister() > failed > mtd: spear_smi: Drop if with an always false condition > mtd: rawnand: atmel: Warn about failure to unregister mtd device > mtd: rawnand: omap2: Suppress error message after WARN in .remove() > mtd: rawnand: tegra: Don't skip cleanup after mtd_device_unregister() > failed > mtd: rawnand: meson: Don't skip cleanup after mtd_device_unregister() > failed > mtd: rawnand: meson: Drop cleaning platform data in .remove() > mtd: physmap: Don't skip cleanup after mtd_device_unregister() failed > mtd: physmap: Drop if with an always false condition >=20 > drivers/mtd/devices/powernv_flash.c | 4 +++- > drivers/mtd/devices/spear_smi.c | 10 ++-------- > drivers/mtd/devices/st_spi_fsm.c | 4 +++- > drivers/mtd/hyperbus/hbmc-am654.c | 6 +++--- > drivers/mtd/hyperbus/hyperbus-core.c | 8 ++------ > drivers/mtd/hyperbus/rpc-if.c | 5 +++-- > drivers/mtd/lpddr/lpddr2_nvm.c | 4 +++- > drivers/mtd/maps/physmap-core.c | 13 +++---------- > drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++- > drivers/mtd/nand/raw/meson_nand.c | 16 +++------------- > drivers/mtd/nand/raw/omap2.c | 6 ++---- > drivers/mtd/nand/raw/tegra_nand.c | 5 +---- > drivers/mtd/spi-nor/controllers/aspeed-smc.c | 8 ++++---- > include/linux/mtd/hyperbus.h | 4 +--- > 14 files changed, 37 insertions(+), 61 deletions(-) >=20 > base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f