From: Liang He <windhl@126.com>
To: krzysztof.kozlowski@linaro.org, thierry.reding@gmail.com,
jonathanh@nvidia.com
Cc: windhl@126.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: [PATCH] memory/tegra: Add missing of_node_get() in tegra_emc_find_node_by_ram_code
Date: Wed, 22 Jun 2022 12:28:24 +0800 [thread overview]
Message-ID: <20220622042824.4094625-1-windhl@126.com> (raw)
of_find_node_by_name() will decrease the refcount of its first arg and
we need to add a of_node_put() to keep refcount balance.
Besides, during the 'for' loop execution, the refcount of 'np' will be
automatically increased and decreased. There is no need to call
of_node_put() again.
Signed-off-by: Liang He <windhl@126.com>
---
drivers/memory/tegra/tegra20-emc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 25ba3c5e4ad6..e43a5f8e188e 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -477,6 +477,7 @@ tegra_emc_find_node_by_ram_code(struct tegra_emc *emc)
ram_code = tegra_read_ram_code();
+ of_get_node(dev->of_node);
for (np = of_find_node_by_name(dev->of_node, "emc-tables"); np;
np = of_find_node_by_name(np, "emc-tables")) {
err = of_property_read_u32(np, "nvidia,ram-code", &value);
@@ -484,6 +485,7 @@ tegra_emc_find_node_by_ram_code(struct tegra_emc *emc)
struct device_node *lpddr2_np;
bool cfg_mismatches = false;
+ of_node_get(np);
lpddr2_np = of_find_node_by_name(np, "lpddr2");
if (lpddr2_np) {
const struct lpddr2_info *info;
@@ -521,7 +523,6 @@ tegra_emc_find_node_by_ram_code(struct tegra_emc *emc)
}
if (cfg_mismatches) {
- of_node_put(np);
continue;
}
}
--
2.25.1
next reply other threads:[~2022-06-22 4:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 4:28 Liang He [this message]
2022-06-22 6:50 ` [PATCH] memory/tegra: Add missing of_node_get() in tegra_emc_find_node_by_ram_code Krzysztof Kozlowski
2022-06-22 6:56 ` Liang He
2022-06-22 8:35 ` kernel test robot
2022-06-22 8:41 ` Krzysztof Kozlowski
2022-06-22 8:49 ` Liang He
2022-06-22 9:08 ` Krzysztof Kozlowski
2022-06-22 9:09 ` Krzysztof Kozlowski
2022-06-22 9:20 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622042824.4094625-1-windhl@126.com \
--to=windhl@126.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox