Re: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

Jason Gunthorpe
2022-09-08T12:08:58Z

On Thu, Sep 08, 2022 at 09:30:57AM +0000, Tian, Kevin wrote:
> > But OK, I'm on board, lets use more common errnos with specific
> > meaning, that can be documented in a comment someplace:
> > ENOMEM - out of memory
> > ENODEV - no domain can attach, device or iommu is messed up
> > EINVAL - the domain is incompatible with the device
> > <others> - Same behavior as ENODEV, use is discouraged.
>
> There are also cases where common kAPIs are called in the attach
> path which may return -EINVAL and random errno, e.g.:
>
> omap_iommu_attach_dev()
> omap_iommu_attach()
> iommu_enable()
> pm_runtime_get_sync()
> __pm_runtime_resume()
> rpm_resume()
> if (dev->power.runtime_error) {
> retval = -EINVAL;
>
> viommu_attach_dev()
> viommu_domain_finalise()
> ida_alloc_range()
> if ((int)min < 0)
> return -ENOSPC;

Yes, this is was also on my mind with choosing an unpopular return
code, it has a higher chance of not coming out of some other kernel
API

> If we think attach_dev is a slow path and having unnecessary retries
> doesn't hurt then -EINVAL sounds a simpler option. We probably can
> just go using -EINVAL as retry indicator in vfio even w/o changing
> iommu drivers at this point. Then improve them to use consistent
> errno gradually and in a separate effort.

Given Joerg's objection I think we will do EINVAL and just live with
the imperfection.

It is not just slow path, but being inaccurate can mean extra domains
are created when they were not needed. But I think we are getting into
sufficiently unlikely territory that issue can be ignored to make
progress.

Jason