From: Jon Hunter <jonathanh@nvidia.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <linux-pwm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH 2/2] pwm: tegra: Fix required rate when clock is lower than needed
Date: Wed, 26 Oct 2022 11:13:05 +0100 [thread overview]
Message-ID: <20221026101305.30670-2-jonathanh@nvidia.com> (raw)
In-Reply-To: <20221026101305.30670-1-jonathanh@nvidia.com>
If the 'required_clk_rate' is greater than the clock rate that can be
provided, then when mul_u64_u64_div_u64() is called to determine the
'rate' for the PWM divider, 0 will be returned. If 'rate' is 0, then we
will return -EINVAL and fail to configure the PWM. Fix this by adding 1
to the PWM_DUTY_WIDTH when calculating the 'required_clk_rate' to ensure
that 'rate' is greater or equal to 1. This fixes an issue on Tegra234
where configuring the PWM fan fails.
Fixes: 8c193f4714df ("pwm: tegra: Optimize period calculation")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/pwm/pwm-tegra.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c
index 8a33c500f93b..973e2c1533ab 100644
--- a/drivers/pwm/pwm-tegra.c
+++ b/drivers/pwm/pwm-tegra.c
@@ -148,6 +148,19 @@ static int tegra_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
required_clk_rate = DIV_ROUND_UP_ULL((NSEC_PER_SEC << PWM_DUTY_WIDTH),
period_ns);
+ /*
+ * If the 'required_clk_rate' is greater than the clock rate
+ * that can be provided, then when mul_u64_u64_div_u64() is
+ * called to determine the 'rate' for the PWM divider, 0 will
+ * be returned. If 'rate' is 0, then we will return -EINVAL and
+ * fail to configure the PWM. If this case, add 1 to the
+ * PWM_DUTY_WIDTH when calculating the 'required_clk_rate' to
+ * ensure that 'rate' is greater or equal to 1.
+ */
+ if (required_clk_rate > clk_round_rate(pc->clk, required_clk_rate))
+ required_clk_rate = DIV_ROUND_UP_ULL((NSEC_PER_SEC << (PWM_DUTY_WIDTH + 1)),
+ period_ns);
+
err = dev_pm_opp_set_rate(pc->dev, required_clk_rate);
if (err < 0)
return -EINVAL;
--
2.25.1
next prev parent reply other threads:[~2022-10-26 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 10:13 [PATCH 1/2] pwm: tegra: Improve required rate calculation Jon Hunter
2022-10-26 10:13 ` Jon Hunter [this message]
2022-10-26 14:23 ` [PATCH 2/2] pwm: tegra: Fix required rate when clock is lower than needed Uwe Kleine-König
2022-10-26 20:17 ` Jon Hunter
2022-10-27 6:40 ` Uwe Kleine-König
2022-10-27 14:17 ` Jon Hunter
2022-10-27 15:40 ` Jon Hunter
2022-10-27 16:09 ` Uwe Kleine-König
2022-10-26 14:17 ` [PATCH 1/2] pwm: tegra: Improve required rate calculation Uwe Kleine-König
2022-10-26 14:24 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026101305.30670-2-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox