* Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
[not found] <20220913101237.4337-1-vidyas@nvidia.com>
@ 2022-10-18 6:21 ` Jon Hunter
2022-10-18 16:43 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Jon Hunter @ 2022-10-18 6:21 UTC (permalink / raw)
To: Vidya Sagar, jingoohan1, gustavo.pimentel, lpieralisi, robh, kw,
bhelgaas, treding
Cc: linux-pci, linux-kernel, kthota, mmaddireddy, sagar.tv,
linux-tegra@vger.kernel.org
Hi Bjorn,
On 13/09/2022 11:12, Vidya Sagar wrote:
> Some of the platforms (like Tegra194 and Tegra234) have open slots and
> not having an endpoint connected to the slot is not an error.
> So, changing the macro from dev_err to dev_info to log the event.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index 650a7f22f9d0..25154555aa7a 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> }
>
> if (retries >= LINK_WAIT_MAX_RETRIES) {
> - dev_err(pci->dev, "Phy link never came up\n");
> + dev_info(pci->dev, "Phy link never came up\n");
> return -ETIMEDOUT;
> }
>
Are you OK to take this change?
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Thanks
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
2022-10-18 6:21 ` [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Jon Hunter
@ 2022-10-18 16:43 ` Bjorn Helgaas
2022-10-26 11:39 ` Jon Hunter
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2022-10-18 16:43 UTC (permalink / raw)
To: Jon Hunter
Cc: Vidya Sagar, jingoohan1, gustavo.pimentel, lpieralisi, robh, kw,
bhelgaas, treding, linux-pci, linux-kernel, kthota, mmaddireddy,
sagar.tv, linux-tegra@vger.kernel.org
On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
> Hi Bjorn,
>
> On 13/09/2022 11:12, Vidya Sagar wrote:
> > Some of the platforms (like Tegra194 and Tegra234) have open slots and
> > not having an endpoint connected to the slot is not an error.
> > So, changing the macro from dev_err to dev_info to log the event.
> >
> > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > ---
> > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > index 650a7f22f9d0..25154555aa7a 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > }
> > if (retries >= LINK_WAIT_MAX_RETRIES) {
> > - dev_err(pci->dev, "Phy link never came up\n");
> > + dev_info(pci->dev, "Phy link never came up\n");
> > return -ETIMEDOUT;
> > }
>
>
> Are you OK to take this change?
When this came up, Lorenzo was in the middle of a big move and I was
covering for him while he was unavailable. But he's back, and I'm
sure he will resolve this soon.
Personally I'm OK either way.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
2022-10-18 16:43 ` Bjorn Helgaas
@ 2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi
2022-10-27 9:55 ` Ben Dooks
0 siblings, 2 replies; 6+ messages in thread
From: Jon Hunter @ 2022-10-26 11:39 UTC (permalink / raw)
To: Bjorn Helgaas, lpieralisi
Cc: Vidya Sagar, jingoohan1, gustavo.pimentel, robh, kw, bhelgaas,
treding, linux-pci, linux-kernel, kthota, mmaddireddy, sagar.tv,
linux-tegra@vger.kernel.org
Hi Lorenzo,
On 18/10/2022 17:43, Bjorn Helgaas wrote:
> On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
>> Hi Bjorn,
>>
>> On 13/09/2022 11:12, Vidya Sagar wrote:
>>> Some of the platforms (like Tegra194 and Tegra234) have open slots and
>>> not having an endpoint connected to the slot is not an error.
>>> So, changing the macro from dev_err to dev_info to log the event.
>>>
>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>> ---
>>> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
>>> index 650a7f22f9d0..25154555aa7a 100644
>>> --- a/drivers/pci/controller/dwc/pcie-designware.c
>>> +++ b/drivers/pci/controller/dwc/pcie-designware.c
>>> @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>>> }
>>> if (retries >= LINK_WAIT_MAX_RETRIES) {
>>> - dev_err(pci->dev, "Phy link never came up\n");
>>> + dev_info(pci->dev, "Phy link never came up\n");
>>> return -ETIMEDOUT;
>>> }
>>
>>
>> Are you OK to take this change?
>
> When this came up, Lorenzo was in the middle of a big move and I was
> covering for him while he was unavailable. But he's back, and I'm
> sure he will resolve this soon.
>
> Personally I'm OK either way.
>
> Bjorn
Can we come to a conclusion on this?
We have tests that fail when errors/warning messages are reported. We
can choose to ignore these errors, but given that this is not an error
in this case, we were thinking it is better to make it informational.
Thanks
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
2022-10-26 11:39 ` Jon Hunter
@ 2022-10-26 12:33 ` Lorenzo Pieralisi
2022-10-27 9:55 ` Ben Dooks
1 sibling, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2022-10-26 12:33 UTC (permalink / raw)
To: Jon Hunter
Cc: Bjorn Helgaas, Vidya Sagar, jingoohan1, gustavo.pimentel, robh,
kw, bhelgaas, treding, linux-pci, linux-kernel, kthota,
mmaddireddy, sagar.tv, linux-tegra@vger.kernel.org
On Wed, Oct 26, 2022 at 12:39:13PM +0100, Jon Hunter wrote:
> Hi Lorenzo,
>
> On 18/10/2022 17:43, Bjorn Helgaas wrote:
> > On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
> > > Hi Bjorn,
> > >
> > > On 13/09/2022 11:12, Vidya Sagar wrote:
> > > > Some of the platforms (like Tegra194 and Tegra234) have open slots and
> > > > not having an endpoint connected to the slot is not an error.
> > > > So, changing the macro from dev_err to dev_info to log the event.
> > > >
> > > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > > > ---
> > > > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > > > index 650a7f22f9d0..25154555aa7a 100644
> > > > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > > > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > > > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > > > }
> > > > if (retries >= LINK_WAIT_MAX_RETRIES) {
> > > > - dev_err(pci->dev, "Phy link never came up\n");
> > > > + dev_info(pci->dev, "Phy link never came up\n");
> > > > return -ETIMEDOUT;
> > > > }
> > >
> > >
> > > Are you OK to take this change?
> >
> > When this came up, Lorenzo was in the middle of a big move and I was
> > covering for him while he was unavailable. But he's back, and I'm
> > sure he will resolve this soon.
> >
> > Personally I'm OK either way.
> >
> > Bjorn
>
>
> Can we come to a conclusion on this?
>
> We have tests that fail when errors/warning messages are reported. We can
> choose to ignore these errors, but given that this is not an error in this
> case, we were thinking it is better to make it informational.
I understood.
We are at v6.1-rc2, this patch is not a fix, we will handle it for the
v6.2 merge window.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi
@ 2022-10-27 9:55 ` Ben Dooks
2022-10-27 11:05 ` Manivannan Sadhasivam
1 sibling, 1 reply; 6+ messages in thread
From: Ben Dooks @ 2022-10-27 9:55 UTC (permalink / raw)
To: Jon Hunter, Bjorn Helgaas, lpieralisi
Cc: Vidya Sagar, jingoohan1, gustavo.pimentel, robh, kw, bhelgaas,
treding, linux-pci, linux-kernel, kthota, mmaddireddy, sagar.tv,
linux-tegra@vger.kernel.org
On 26/10/2022 12:39, Jon Hunter wrote:
> Hi Lorenzo,
>
> On 18/10/2022 17:43, Bjorn Helgaas wrote:
>> On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
>>> Hi Bjorn,
>>>
>>> On 13/09/2022 11:12, Vidya Sagar wrote:
>>>> Some of the platforms (like Tegra194 and Tegra234) have open slots and
>>>> not having an endpoint connected to the slot is not an error.
>>>> So, changing the macro from dev_err to dev_info to log the event.
>>>>
>>>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>>>> ---
>>>> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c
>>>> b/drivers/pci/controller/dwc/pcie-designware.c
>>>> index 650a7f22f9d0..25154555aa7a 100644
>>>> --- a/drivers/pci/controller/dwc/pcie-designware.c
>>>> +++ b/drivers/pci/controller/dwc/pcie-designware.c
>>>> @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>>>> }
>>>> if (retries >= LINK_WAIT_MAX_RETRIES) {
>>>> - dev_err(pci->dev, "Phy link never came up\n");
>>>> + dev_info(pci->dev, "Phy link never came up\n");
>>>> return -ETIMEDOUT;
>>>> }
>>>
>>>
>>> Are you OK to take this change?
>>
>> When this came up, Lorenzo was in the middle of a big move and I was
>> covering for him while he was unavailable. But he's back, and I'm
>> sure he will resolve this soon.
>>
>> Personally I'm OK either way.
>>
>> Bjorn
>
>
> Can we come to a conclusion on this?
>
> We have tests that fail when errors/warning messages are reported. We
> can choose to ignore these errors, but given that this is not an error
> in this case, we were thinking it is better to make it informational.
Is there any hardware presence detect available to just avoid even
trying to bring a link up on an disconnected port?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
2022-10-27 9:55 ` Ben Dooks
@ 2022-10-27 11:05 ` Manivannan Sadhasivam
0 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-10-27 11:05 UTC (permalink / raw)
To: Ben Dooks
Cc: Jon Hunter, Bjorn Helgaas, lpieralisi, Vidya Sagar, jingoohan1,
gustavo.pimentel, robh, kw, bhelgaas, treding, linux-pci,
linux-kernel, kthota, mmaddireddy, sagar.tv,
linux-tegra@vger.kernel.org
On Thu, Oct 27, 2022 at 10:55:34AM +0100, Ben Dooks wrote:
> On 26/10/2022 12:39, Jon Hunter wrote:
> > Hi Lorenzo,
> >
> > On 18/10/2022 17:43, Bjorn Helgaas wrote:
> > > On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
> > > > Hi Bjorn,
> > > >
> > > > On 13/09/2022 11:12, Vidya Sagar wrote:
> > > > > Some of the platforms (like Tegra194 and Tegra234) have open slots and
> > > > > not having an endpoint connected to the slot is not an error.
> > > > > So, changing the macro from dev_err to dev_info to log the event.
> > > > >
> > > > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > > > > ---
> > > > > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c
> > > > > b/drivers/pci/controller/dwc/pcie-designware.c
> > > > > index 650a7f22f9d0..25154555aa7a 100644
> > > > > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > > > > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > > > > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > > > > }
> > > > > if (retries >= LINK_WAIT_MAX_RETRIES) {
> > > > > - dev_err(pci->dev, "Phy link never came up\n");
> > > > > + dev_info(pci->dev, "Phy link never came up\n");
> > > > > return -ETIMEDOUT;
> > > > > }
> > > >
> > > >
> > > > Are you OK to take this change?
> > >
> > > When this came up, Lorenzo was in the middle of a big move and I was
> > > covering for him while he was unavailable. But he's back, and I'm
> > > sure he will resolve this soon.
> > >
> > > Personally I'm OK either way.
> > >
> > > Bjorn
> >
> >
> > Can we come to a conclusion on this?
> >
> > We have tests that fail when errors/warning messages are reported. We
> > can choose to ignore these errors, but given that this is not an error
> > in this case, we were thinking it is better to make it informational.
>
> Is there any hardware presence detect available to just avoid even
> trying to bring a link up on an disconnected port?
>
PRSNT pin is not available on all form factors sadly.
Thanks,
Mani
>
> --
> Ben Dooks http://www.codethink.co.uk/
> Senior Engineer Codethink - Providing Genius
>
> https://www.codethink.co.uk/privacy.html
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-27 11:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220913101237.4337-1-vidyas@nvidia.com>
2022-10-18 6:21 ` [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Jon Hunter
2022-10-18 16:43 ` Bjorn Helgaas
2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi
2022-10-27 9:55 ` Ben Dooks
2022-10-27 11:05 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).