public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
	<gregkh@linuxfoundation.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<robh+dt@kernel.org>, <vkoul@kernel.org>, <treding@nvidia.com>
Cc: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-phy@lists.infradead.org>, <linux-tegra@vger.kernel.org>,
	<waynec@nvidia.com>, Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH V4 3/6] phy: tegra: xusb: Disable trk clk when not in use
Date: Fri, 18 Nov 2022 15:40:03 +0000	[thread overview]
Message-ID: <20221118154006.173082-4-jonathanh@nvidia.com> (raw)
In-Reply-To: <20221118154006.173082-1-jonathanh@nvidia.com>

From: Wayne Chang <waynec@nvidia.com>

Pad tracking is a one-time calibration for Tegra186 and Tegra194.
Clk should be disabled after calibration.

Disable clk after calibration.
While at it add 100us delay for HW recording the calibration value.

Signed-off-by: Wayne Chang <waynec@nvidia.com>
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
V3 -> V4: nothing has changed
V2 -> V3: nothing has changed
V1 -> V2: update the commit message.

 drivers/phy/tegra/xusb-tegra186.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
index 6a8bd87cfdbd..c00d14f27ab4 100644
--- a/drivers/phy/tegra/xusb-tegra186.c
+++ b/drivers/phy/tegra/xusb-tegra186.c
@@ -609,6 +609,10 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
 	value &= ~USB2_PD_TRK;
 	padctl_writel(padctl, value, XUSB_PADCTL_USB2_BIAS_PAD_CTL1);
 
+	udelay(100);
+
+	clk_disable_unprepare(priv->usb2_trk_clk);
+
 	mutex_unlock(&padctl->lock);
 }
 
@@ -633,8 +637,6 @@ static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)
 	value |= USB2_PD_TRK;
 	padctl_writel(padctl, value, XUSB_PADCTL_USB2_BIAS_PAD_CTL1);
 
-	clk_disable_unprepare(priv->usb2_trk_clk);
-
 	mutex_unlock(&padctl->lock);
 }
 
-- 
2.25.1


  parent reply	other threads:[~2022-11-18 15:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 15:40 [PATCH V4 0/6] Enable USB host on Jetson AGX Orin Jon Hunter
2022-11-18 15:40 ` [PATCH V4 1/6] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding Jon Hunter
2022-11-18 18:50   ` Rob Herring
2022-11-18 15:40 ` [PATCH V4 2/6] arm64: tegra: Enable XUSB host function on Jetson AGX Orin Jon Hunter
2022-11-18 15:40 ` Jon Hunter [this message]
2022-11-18 15:40 ` [PATCH V4 4/6] phy: tegra: xusb: Add Tegra234 support Jon Hunter
2022-11-18 15:40 ` [PATCH V4 5/6] usb: host: xhci-tegra: Add Tegra234 XHCI support Jon Hunter
2022-11-22 16:07   ` Greg KH
2022-11-23 14:20     ` Jon Hunter
2022-11-24 12:30       ` Wayne Chang
2022-11-18 15:40 ` [PATCH V4 6/6] dt-bindings: phy: tegra-xusb: Add support for Tegra234 Jon Hunter
2022-11-30 17:07   ` Rob Herring
2022-12-02  9:53     ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221118154006.173082-4-jonathanh@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    --cc=vkoul@kernel.org \
    --cc=waynec@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox