Linux Tegra architecture development
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-tegra@vger.kernel.org>, <thierry.reding@gmail.com>,
	<airlied@gmail.com>, <daniel@ffwll.ch>, <mperttunen@nvidia.com>,
	<cyndis@kapsi.fi>
Cc: <yangyingliang@huawei.com>
Subject: [PATCH v2 resend 1/2] gpu: host1x: fix potential double free if IOMMU is disabled
Date: Sat, 26 Nov 2022 15:33:14 +0800	[thread overview]
Message-ID: <20221126073315.365567-2-yangyingliang@huawei.com> (raw)
In-Reply-To: <20221126073315.365567-1-yangyingliang@huawei.com>

If context device has no IOMMU, the 'cdl->devs' is freed in
error path, but host1x_memory_context_list_init() doesn't
return an error code, so the module can be loaded successfully,
when it's unloading, the host1x_memory_context_list_free() is
called in host1x_remove(), it will cause double free. Set the
'cdl->devs' to NULL after freeing it to avoid double free.

Fixes: 8aa5bcb61612 ("gpu: host1x: Add context device management code")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/gpu/host1x/context.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/host1x/context.c b/drivers/gpu/host1x/context.c
index b08cf11f9a66..291f34562e2e 100644
--- a/drivers/gpu/host1x/context.c
+++ b/drivers/gpu/host1x/context.c
@@ -87,6 +87,7 @@ int host1x_memory_context_list_init(struct host1x *host1x)
 		device_del(&cdl->devs[i].dev);
 
 	kfree(cdl->devs);
+	cdl->devs = NULL;
 	cdl->len = 0;
 
 	return err;
-- 
2.25.1


  reply	other threads:[~2022-11-26  7:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-26  7:33 [PATCH v2 resend 0/2] gpu: host1x: possible double free and memory leak Yang Yingliang
2022-11-26  7:33 ` Yang Yingliang [this message]
2022-11-28  9:47   ` [PATCH v2 resend 1/2] gpu: host1x: fix potential double free if IOMMU is disabled Mikko Perttunen
2023-04-04 12:25   ` (subset) " Thierry Reding
2022-11-26  7:33 ` [PATCH v2 resend 2/2] gpu: host1x: fix memory leak of device names Yang Yingliang
2022-11-28  9:53   ` Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221126073315.365567-2-yangyingliang@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=airlied@gmail.com \
    --cc=cyndis@kapsi.fi \
    --cc=daniel@ffwll.ch \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mperttunen@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox