From: Thierry Reding <thierry.reding@gmail.com>
To: Joerg Roedel <joro@8bytes.org>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Prathamesh Shete <pshete@nvidia.com>,
Will Deacon <will@kernel.org>,
iommu@lists.linux-foundation.org, linux-mmc@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: [PATCH v13 2/6] iommu/tegra: Add tegra_dev_iommu_get_stream_id() helper
Date: Tue, 6 Dec 2022 17:59:41 +0100 [thread overview]
Message-ID: <20221206165945.3551774-3-thierry.reding@gmail.com> (raw)
In-Reply-To: <20221206165945.3551774-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
Access to the internals of struct iommu_fwspec by non-IOMMU drivers is
discouraged. Many drivers for Tegra SoCs, however, need access to their
IOMMU stream IDs so that they can be programmed into various hardware
registers.
Formalize this access into a common helper to make it easier to audit
and maintain.
Acked-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
include/linux/iommu.h | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index dc5e6f5c14fc..f0d72acad7db 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -1186,4 +1186,25 @@ static inline u32 iommu_sva_get_pasid(struct iommu_sva *handle)
}
#endif /* CONFIG_IOMMU_SVA */
+/*
+ * Newer generations of Tegra SoCs require devices' stream IDs to be directly programmed into
+ * some registers. These are always paired with a Tegra SMMU or ARM SMMU, for which the contents
+ * of the struct iommu_fwspec are known. Use this helper to formalize access to these internals.
+ */
+#define TEGRA_STREAM_ID_BYPASS 0x7f
+
+static inline bool tegra_dev_iommu_get_stream_id(struct device *dev, u32 *stream_id)
+{
+#ifdef CONFIG_IOMMU_API
+ struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
+
+ if (fwspec && fwspec->num_ids == 1) {
+ *stream_id = fwspec->ids[0] & 0xffff;
+ return true;
+ }
+#endif
+
+ return false;
+}
+
#endif /* __LINUX_IOMMU_H */
--
2.38.1
next prev parent reply other threads:[~2022-12-06 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 16:59 [PATCH v13 0/6] mmc: sdhci: Add Tegra234 support Thierry Reding
2022-12-06 16:59 ` [PATCH v13 1/6] iommu: Add note about struct iommu_fwspec usage Thierry Reding
2022-12-06 16:59 ` Thierry Reding [this message]
2022-12-06 16:59 ` [PATCH v13 3/6] mmc: sdhci-tegra: Sort includes alphabetically Thierry Reding
2022-12-06 16:59 ` [PATCH v13 4/6] mmc: sdhci-tegra: Separate Tegra194 and Tegra234 SoC data Thierry Reding
2022-12-06 16:59 ` [PATCH v13 5/6] mmc: sdhci-tegra: Add support to program MC stream ID Thierry Reding
2022-12-06 16:59 ` [PATCH v13 6/6] mmc: sdhci-tegra: Issue CMD and DAT resets together Thierry Reding
2022-12-07 12:37 ` [PATCH v13 0/6] mmc: sdhci: Add Tegra234 support Ulf Hansson
2022-12-07 23:47 ` Stephen Rothwell
2022-12-08 0:04 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206165945.3551774-3-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox