From: Thierry Reding <thierry.reding@gmail.com>
To: David Airlie <airlied@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Robin Murphy <robin.murphy@arm.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v4 0/8] drm/simpledrm: Support system memory framebuffers
Date: Fri, 20 Jan 2023 18:30:55 +0100 [thread overview]
Message-ID: <20230120173103.4002342-1-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
Hi,
this series of patches adds support for framebuffers residing in system
memory to the simple-framebuffer DRM driver. To do this, the DT bindings
are extended do accept the memory-region property in addition to the reg
property for specifying the framebuffer memory. This is done because the
framebuffer memory will typically also need to be marked as reserved so
that the operating system will not reuse it and the memory-region
property is the standard property to reference reserved memory regions.
A new compatible string is documented to annotate the framebuffer memory
regions and the simpledrm driver has code added to bind such annotated
regions to the simple-framebuffer device.
The second half of the series then adds support for the XB24 and AB24
formats and ties it all together to provide a simple-framebuffer on
Jetson Xavier NX. It should be noted, though, that the Jetson Xavier NX
device tree nodes are placeholders only and it is expected that firmware
or a bootloader will fill these in at runtime, due to the variable
nature of the values that they contain.
This example also uses (but doesn't depend on) the iommu-addresses
property that has been proposed and which will hopefully be merged soon.
Version 3 of these patches can be found here:
https://lore.kernel.org/all/20221117184039.2291937-1-thierry.reding@gmail.com/
Changes in v4:
- rebase onto latest format helper changes, add back AB24 support
- use drm_dbg() instead of drm_info() for some messages
- use consistent name for iosys_map structures
- collect Reviewed-bys from v3
Changes in v3:
- add new formats into conv_from_xrgb8888[] array to make it work after
commit 6fdaed8c7988 ("drm/format-helper: Only advertise supported
formats for conversion")
- extract iosys_map fix into a separate patch
- fix bogus increments in struct iosys_map usage
- simplify memory code
Changes in v2:
- DT fields are now cleared so that they can be filled in at runtime
- add XB24 support and treat AB24 the same (alpha bits are unused)
- consistently use struct iosys_map
- fix issues with DT bindings
I've tested these with a simple UEFI implementation that will fill in
the placeholder values and set the simple-framebuffer's status property
to "okay".
Thierry
Thierry Reding (8):
dt-bindings: display: simple-framebuffer: Support system memory
framebuffers
dt-bindings: display: simple-framebuffer: Document 32-bit BGR format
dt-bindings: reserved-memory: Support framebuffer reserved memory
drm/simpledrm: Use struct iosys_map consistently
drm/simpledrm: Add support for system memory framebuffers
drm/format-helper: Support the AB24/XB24 formats
drm/simpledrm: Support the XB24/AB24 format
arm64: tegra: Add simple framebuffer on Jetson Xavier NX
.../bindings/display/simple-framebuffer.yaml | 7 ++
.../bindings/reserved-memory/framebuffer.yaml | 52 +++++++++
.../nvidia/tegra194-p3509-0000+p3668-0001.dts | 43 +++++++
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 2 +-
drivers/gpu/drm/drm_format_helper.c | 66 +++++++++++
drivers/gpu/drm/tiny/simpledrm.c | 110 +++++++++++++-----
include/linux/platform_data/simplefb.h | 1 +
7 files changed, 251 insertions(+), 30 deletions(-)
create mode 100644 Documentation/devicetree/bindings/reserved-memory/framebuffer.yaml
--
2.39.0
next reply other threads:[~2023-01-20 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 17:30 Thierry Reding [this message]
2023-01-20 17:30 ` [PATCH v4 1/8] dt-bindings: display: simple-framebuffer: Support system memory framebuffers Thierry Reding
2023-01-20 17:30 ` [PATCH v4 2/8] dt-bindings: display: simple-framebuffer: Document 32-bit BGR format Thierry Reding
2023-01-20 17:30 ` [PATCH v4 3/8] dt-bindings: reserved-memory: Support framebuffer reserved memory Thierry Reding
2023-01-20 17:30 ` [PATCH v4 4/8] drm/simpledrm: Use struct iosys_map consistently Thierry Reding
2023-01-20 17:31 ` [PATCH v4 5/8] drm/simpledrm: Add support for system memory framebuffers Thierry Reding
2023-01-20 17:31 ` [PATCH v4 6/8] drm/format-helper: Support the AB24/XB24 formats Thierry Reding
2023-01-20 17:31 ` [PATCH v4 7/8] drm/simpledrm: Support the XB24/AB24 format Thierry Reding
2023-01-23 9:16 ` Thomas Zimmermann
2023-01-23 15:19 ` Thierry Reding
2023-01-20 17:31 ` [PATCH v4 8/8] arm64: tegra: Add simple framebuffer on Jetson Xavier NX Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120173103.4002342-1-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox