From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: <perex@perex.cz>, <tiwai@suse.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <james.schulman@cirrus.com>,
<david.rhodes@cirrus.com>, <tanureal@opensource.cirrus.com>,
<rf@opensource.cirrus.com>, <oder_chiou@realtek.com>,
<shengjiu.wang@gmail.com>, <Xiubo.Lee@gmail.com>,
<festevam@gmail.com>, <nicoleotsuka@gmail.com>,
<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
<kernel@pengutronix.de>, <linux-imx@nxp.com>,
<cezary.rojewski@intel.com>,
<pierre-louis.bossart@linux.intel.com>,
<peter.ujfalusi@linux.intel.com>,
<yung-chuan.liao@linux.intel.com>,
<ranjani.sridharan@linux.intel.com>,
<kai.vehmanen@linux.intel.com>, <matthias.bgg@gmail.com>,
<srinivas.kandagatla@linaro.org>, <bgoswami@quicinc.com>,
<vkoul@kernel.org>, <daniel.baluta@nxp.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<jarkko.nikula@bitmer.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
<linuxppc-dev@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<sound-open-firmware@alsa-project.org>,
<linux-tegra@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ASoC: do not include pm_runtime.h if not used
Date: Tue, 7 Mar 2023 11:30:16 +0000 [thread overview]
Message-ID: <20230307113016.GS68926@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230307103022.1007420-1-claudiu.beznea@microchip.com>
On Tue, Mar 07, 2023 at 12:30:22PM +0200, Claudiu Beznea wrote:
> Do not include pm_runtime.h header in files where runtime PM support is
> not implemented.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> sound/soc/codecs/cs35l45.h | 1 -
> diff --git a/sound/soc/codecs/cs35l45.h b/sound/soc/codecs/cs35l45.h
> index 53fe9d2b7b15..0555702eac03 100644
> --- a/sound/soc/codecs/cs35l45.h
> +++ b/sound/soc/codecs/cs35l45.h
> @@ -11,7 +11,6 @@
> #ifndef CS35L45_H
> #define CS35L45_H
>
> -#include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
>
cs35l45 does already make use of some functions from that header,
and more support is in the process of being upstreamed. So this
part should be dropped.
Thanks,
Charles
next prev parent reply other threads:[~2023-03-07 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 10:30 [PATCH] ASoC: do not include pm_runtime.h if not used Claudiu Beznea
2023-03-07 11:30 ` Charles Keepax [this message]
2023-03-10 7:06 ` Jarkko Nikula
2023-03-10 7:29 ` Srinivas Kandagatla
2023-03-10 8:12 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307113016.GS68926@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.baluta@nxp.com \
--cc=david.rhodes@cirrus.com \
--cc=festevam@gmail.com \
--cc=james.schulman@cirrus.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jonathanh@nvidia.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthias.bgg@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tanureal@opensource.cirrus.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox