From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C632C77B79 for ; Mon, 17 Apr 2023 06:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjDQGTe (ORCPT ); Mon, 17 Apr 2023 02:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjDQGTd (ORCPT ); Mon, 17 Apr 2023 02:19:33 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 714BA3AA8; Sun, 16 Apr 2023 23:19:21 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B70CC75B; Mon, 17 Apr 2023 08:19:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1681712352; bh=hUS3oAOWF+giUHWBAsyfYtTSnpYPnmumb+DnGnesqJ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q+UHkgsqoMg+RbmFKgO/pKG4ltOgU+p0CEbmAeVPPRN4I/Z0MDEKluVIEqTeJBTh9 iHu44ev6JJI4FvruskDtoyatzHO41OXYRlqntM4853wlvujiEUW9lTQTFW+9URIaRu Pthp2nfBkldHSvMHEeDw0JIfxddwHLTf+oIOMJpY= Date: Mon, 17 Apr 2023 09:19:28 +0300 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Mauro Carvalho Chehab , linux-aspeed@lists.ozlabs.org, Alim Akhtar , Hans Verkuil , Benson Leung , Ajye Huang , Rory Liu , Scott Chao , Neil Armstrong , Kevin Hilman , Marek Szyprowski , Ettore Chimenti , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Sean Young , Sakari Ailus , Ricardo Ribalda , Yang Yingliang , Thierry Reding , Jonathan Hunter , Antti Palosaari , Michael Tretter , Ming Qian , Zhou Peng , Eddie James , Joel Stanley , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Maxime Ripard , Philipp Zabel , Bin Liu , Matthias Brugger , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Moudy Ho , Qiheng Lin , Tiffany Lin , Yunfei Dong , Dmitry Osipenko , Xavier Roumegue , Mirela Rabulea , Shawn Guo , Sascha Hauer , Rui Miguel Silva , Robert Foss , Todor Tomov , Andy Gross , Bjorn Andersson , Stanimir Varbanov , Vikash Garodia , Niklas =?utf-8?Q?S=C3=B6derlund?= , Fabrizio Castro , Kieran Bingham , Mikhail Ulyanov , Jacopo Mondi , Lad Prabhakar , Nathan Chancellor , Yang Li , Dan Carpenter , Jacob Chen , Ezequiel Garcia , Heiko Stuebner , Dafna Hirschfeld , Krzysztof Kozlowski , Colin Ian King , Sylwester Nawrocki , Sylwester Nawrocki , =?utf-8?Q?=C5=81ukasz?= Stelmach , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Patrice Chotard , Hugues Fruchet , Jean-Christophe Trotin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Yong Deng , Paul Kocialkowski , Christophe JAILLET , "Lad, Prabhakar" , Benoit Parrot , Hyun Kwon , Michal Simek , ye xingchen , Eduardo Valentin , Sean Wang , "Daniel W. S. Almeida" , Shuah Khan , Daniel Almeida , Hans Verkuil , Guenter Roeck , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , chrome-platform@lists.linux.dev, linux-samsung-soc@vger.kernel.org, Konrad Dybcio , openbmc@lists.ozlabs.org, Kieran Bingham , linux-rockchip@lists.infradead.org, NXP Linux Team , linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 000/117] media: Convert to platform remove callback returning void Message-ID: <20230417061928.GD28551@pendragon.ideasonboard.com> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230417060203.le3izz56wt73si6k@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230417060203.le3izz56wt73si6k@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Uwe, On Mon, Apr 17, 2023 at 08:02:03AM +0200, Uwe Kleine-König wrote: > Hello Mauro > > On Sun, Mar 26, 2023 at 04:30:25PM +0200, Uwe Kleine-König wrote: > > Hello, > > > > this series adapts the platform drivers below drivers/pci to use the > > copy&paste failure here: s/pci/media/ of course. > > > .remove_new() callback. Compared to the traditional .remove() callback > > .remove_new() returns no value. This is a good thing because the driver core > > doesn't (and cannot) cope for errors during remove. The only effect of a > > non-zero return value in .remove() is that the driver core emits a warning. The > > device is removed anyhow and an early return from .remove() usually yields a > > resource leak. > > > > By changing the remove callback to return void driver authors cannot > > reasonably assume any more that there is some kind of cleanup later. > > > > Only three drivers needed some preparation first to make sure they > > return 0 unconditionally in their remove callback. Then all drivers > > could be trivially converted without side effects to .remove_new(). > > > > The changes to the individual drivers are all orthogonal. If I need to > > resend some patches because of some review feedback, I'd like to only > > send the patches that actually needed changes, so please pick up the > > remaining patches that don't need changing to reduce the amount of mail. > > I didn't hear anything back about application of this series. Is there a > blocker somewhere? I think the series got applied to the master branch of git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git. It should thus appear in v6.4. The corresponding series for staging media drivers has also been applied to the same branch as far as I can tell. > Apart from the three preparatory patches that are a precondition to the > conversion of the respective drivers, the patches are all pairwise > orthogonal. So from my POV the best would be to apply all patches that > still apply (which might be all), I will care for the fallout later > then. -- Regards, Laurent Pinchart