From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A904C77B76 for ; Mon, 17 Apr 2023 07:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbjDQHhL (ORCPT ); Mon, 17 Apr 2023 03:37:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230218AbjDQHgm (ORCPT ); Mon, 17 Apr 2023 03:36:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDAF449CC; Mon, 17 Apr 2023 00:35:20 -0700 (PDT) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 10E72DE6; Mon, 17 Apr 2023 09:35:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1681716911; bh=+nNnkWr6Y0n06KrbbCtAOSHIusgnvBhnkukVuDNhkEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NbcvuQnyQJAGVrRDp382kWJkH39Ilus9pmqcciT6N67Pdpgd9FeFZlZZ9XsqwFkHA Hzp4QDnGHlkDQGFg8p4k3P9nhygT8DNN9tzAcFlOgEHnSZXwgRJBNMHh4MaQ2gyksv vBVHMMH+GTSQftGIrThbwBm2FcmUTup6+MKy2H7I= Date: Mon, 17 Apr 2023 10:35:27 +0300 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Heiko Stuebner , Eddie James , Hans Verkuil , Alim Akhtar , Dmitry Osipenko , linux-stm32@st-md-mailman.stormreply.com, Marek Szyprowski , linux-samsung-soc@vger.kernel.org, Robert Foss , Dafna Hirschfeld , Samuel Holland , Kevin Hilman , Michal Simek , Antti Palosaari , NXP Linux Team , Jerome Brunet , linux-sunxi@lists.linux.dev, ye xingchen , Sascha Hauer , =?utf-8?Q?=C5=81ukasz?= Stelmach , Eugen Hristev , Shuah Khan , Hyun Kwon , Andrew Jeffery , Michael Tretter , Moudy Ho , kernel@pengutronix.de, Hans Verkuil , Claudiu Beznea , Ming Qian , Andrew-CT Chen , Alexandre Belloni , Sylwester Nawrocki , linux-aspeed@lists.ozlabs.org, Yunfei Dong , "Lad, Prabhakar" , Thierry Reding , Guenter Roeck , chrome-platform@lists.linux.dev, Jonathan Hunter , linux-rockchip@lists.infradead.org, Fabien Dessenne , Ezequiel Garcia , Alain Volmat , Andrzej Pietrasiewicz , Colin Ian King , linux-media@vger.kernel.org, Jacopo Mondi , Rory Liu , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Sean Wang , Maxime Ripard , Fabrizio Castro , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong , Zhou Peng , Paul Kocialkowski , Maxime Coquelin , linux-mediatek@lists.infradead.org, Jacek Anaszewski , Dan Carpenter , Sean Young , Xavier Roumegue , Ettore Chimenti , Vikash Garodia , linux-tegra@vger.kernel.org, Eduardo Valentin , Andrzej Hajda , Fabio Estevam , Jean-Christophe Trotin , Stanimir Varbanov , Kieran Bingham , Jernej Skrabec , Chen-Yu Tsai , Jacob Chen , Joel Stanley , Yang Yingliang , Patrice Chotard , Bin Liu , Nathan Chancellor , Sylwester Nawrocki , Mauro Carvalho Chehab , Benson Leung , "Daniel W. S. Almeida" , Qiheng Lin , Konrad Dybcio , Kieran Bingham , Yang Li , Sakari Ailus , Ricardo Ribalda , Shawn Guo , Minghsiu Tsai , Daniel Almeida , Alexandre Torgue , Todor Tomov , Mirela Rabulea , Ajye Huang , Scott Chao , linux-renesas-soc@vger.kernel.org, Hugues Fruchet , openbmc@lists.ozlabs.org, Andy Gross , Mikhail Ulyanov , Lad Prabhakar , Benoit Parrot , Rui Miguel Silva , Christophe JAILLET , Yong Deng , Matthias Brugger , Tiffany Lin , AngeloGioacchino Del Regno , Bjorn Andersson , Nicolas Ferre , Houlong Wei , Krzysztof Kozlowski , Philipp Zabel , Niklas =?utf-8?Q?S=C3=B6derlund?= Subject: Re: [PATCH 000/117] media: Convert to platform remove callback returning void Message-ID: <20230417073527.GE28551@pendragon.ideasonboard.com> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230417060203.le3izz56wt73si6k@pengutronix.de> <20230417061928.GD28551@pendragon.ideasonboard.com> <20230417073049.2b5b35hpjrjcrlge@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230417073049.2b5b35hpjrjcrlge@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Mon, Apr 17, 2023 at 09:30:49AM +0200, Uwe Kleine-König wrote: > Hello Laurent, > > On Mon, Apr 17, 2023 at 09:19:28AM +0300, Laurent Pinchart wrote: > > On Mon, Apr 17, 2023 at 08:02:03AM +0200, Uwe Kleine-König wrote: > > > On Sun, Mar 26, 2023 at 04:30:25PM +0200, Uwe Kleine-König wrote: > > > > Hello, > > > > > > > > this series adapts the platform drivers below drivers/pci to use the > > > > > > copy&paste failure here: s/pci/media/ of course. > > > > > > > .remove_new() callback. Compared to the traditional .remove() callback > > > > .remove_new() returns no value. This is a good thing because the driver core > > > > doesn't (and cannot) cope for errors during remove. The only effect of a > > > > non-zero return value in .remove() is that the driver core emits a warning. The > > > > device is removed anyhow and an early return from .remove() usually yields a > > > > resource leak. > > > > > > > > By changing the remove callback to return void driver authors cannot > > > > reasonably assume any more that there is some kind of cleanup later. > > > > > > > > Only three drivers needed some preparation first to make sure they > > > > return 0 unconditionally in their remove callback. Then all drivers > > > > could be trivially converted without side effects to .remove_new(). > > > > > > > > The changes to the individual drivers are all orthogonal. If I need to > > > > resend some patches because of some review feedback, I'd like to only > > > > send the patches that actually needed changes, so please pick up the > > > > remaining patches that don't need changing to reduce the amount of mail. > > > > > > I didn't hear anything back about application of this series. Is there a > > > blocker somewhere? > > > > I think the series got applied to the master branch of > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git. > > It should thus appear in v6.4. > > I guess that linux-stable.git is a copy&paste failure (and it's not > there). I don't see the series in the master branch of > git://linuxtv.org/media_tree.git either. Oops sorry. It was a copy & paste mistake indeed, I meant git://linuxtv.org/media_stage.git > .. a bit later ... > > ah, it's in git://linuxtv.org/mchehab/media-next.git > > I guess I was just to quick and probably the series will be included in > today's next. -- Regards, Laurent Pinchart