Re: [PATCH 00/15] PCI: Convert to platform remove callback returning void

Bjorn Helgaas
2023-06-12T16:20:20Z

On Sun, Jun 11, 2023 at 03:24:23PM +0200, Pali Rohár wrote:
> On Friday 02 June 2023 16:37:34 Bjorn Helgaas wrote:
> > On Tue, May 30, 2023 at 04:07:42PM +0200, Uwe Kleine-König wrote:
> > > On Tue, Mar 21, 2023 at 08:31:53PM +0100, Uwe Kleine-König wrote:
> > > > this series adapts the platform drivers below drivers/pci to
> > > > use the .remove_new() callback. Compared to the traditional
> > > > .remove() callback .remove_new() returns no value. This is a
> > > > good thing because the driver core doesn't (and cannot) cope
> > > > for errors during remove. The only effect of a non-zero return
> > > > value in .remove() is that the driver core emits a warning.
> > > > The device is removed anyhow and an early return from
> > > > .remove() usually yields a resource leak.
> ...

> Hello Bjorn, it should be expected that other changes for PCIe drivers
> sent by other people which were sent to the list before this patch
> series and are still waiting for the review (because are without
> comments), would be processed before and patches sent later.

I don't think it's necessary to delay simple, easily-reviewed changes
behind more complicated ones.

> Also I would like to point out that in past I have sent fixes for PCIe
> mvebu driver, which is currently in the broken state. And this is also
> on waiting on the list.

Thanks for this reminder. Would you mind reposting them? I poked
around in patchwork and I must be doing something wrong because I
can't find *any* patches from you, though obviously there are many.

If you repost them at least we'll know unambiguously what is on the
table.

Bjorn