From: Benjamin Bara <bbara93@gmail.com>
To: dmitry.osipenko@collabora.com, konstantin@linuxfoundation.org
Cc: bbara93@gmail.com, benjamin.bara@skidata.com,
jonathanh@nvidia.com, lee@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
peterz@infradead.org, rafael.j.wysocki@intel.com,
richard.leitner@linux.dev, treding@nvidia.com,
wsa+renesas@sang-engineering.com, wsa@kernel.org
Subject: Re: [PATCH v7 5/5] mfd: tps6586x: register restart handler
Date: Wed, 19 Jul 2023 10:22:51 +0200 [thread overview]
Message-ID: <20230719082251.3501424-1-bbara93@gmail.com> (raw)
In-Reply-To: <215679f1-a866-1e92-1bab-9c80918927a6@collabora.com>
Hi Dmitry,
thanks for the feedback!
On Tue, 18 Jul 2023 at 06:46, Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote:
> 15.07.2023 10:53, Benjamin Bara пишет:
> >
> > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > Acked-for-MFD-by: Lee Jones <lee@kernel.org>
>
> Acked-for-MFD-by isn't a valid tag, scripts/checkpatch.pl should tell
> you about it.
>
> In general you may add a comment to a tag, like this:
>
> Acked-by: Lee Jones <lee@kernel.org> # for MFD
>
> In this particular case, the comment is unnecessary because Lee is the
> MFD maintainer, hence his ack itself implies the MFD subsys.
I saw the warning, but Lee requested to add it like this [1].
@Konstantin:
Do you think it makes sense to print a warning when adding "non-standard
trailers" during running "b4 trailers -u", maybe around the
find_trailers() checks? I could provide a RFC, if considered useful.
Best regards,
Benjamin
[1] https://lore.kernel.org/all/20230518094434.GD404509@google.com/
next prev parent reply other threads:[~2023-07-19 8:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 7:53 [PATCH v7 0/5] mfd: tps6586x: register restart handler Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 1/5] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 2/5] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-11-13 1:12 ` Chris Morgan
2023-11-13 3:46 ` Dmitry Osipenko
2023-11-13 14:54 ` Chris Morgan
2023-11-13 15:48 ` Benjamin Bara
2023-11-14 18:43 ` Chris Morgan
2023-11-15 6:00 ` Dmitry Osipenko
2024-01-02 15:03 ` [PATCH v7 2/5] " Michael Walle
2024-01-02 21:02 ` Benjamin Bara
2024-01-03 9:20 ` Michael Walle
2024-01-03 12:49 ` Benjamin Bara
2024-01-03 15:07 ` Michael Walle
2023-07-15 7:53 ` [PATCH v7 3/5] kernel/reboot: add device to sys_off_handler Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 4/5] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 5/5] mfd: tps6586x: register restart handler Benjamin Bara
2023-07-18 4:46 ` Dmitry Osipenko
2023-07-19 8:22 ` Benjamin Bara [this message]
2023-07-19 8:44 ` Lee Jones
2023-07-19 18:22 ` Konstantin Ryabitsev
2023-07-28 10:33 ` [PATCH v7 0/5] " Lee Jones
2023-07-28 10:34 ` Lee Jones
2023-09-07 8:20 ` Benjamin Bara
2023-09-14 10:17 ` Lee Jones
2023-09-19 14:46 ` [GIT PULL] Immutable branch between MFD, I2C and Reboot due for the v6.7 merge window Lee Jones
2023-09-19 14:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719082251.3501424-1-bbara93@gmail.com \
--to=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=konstantin@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=treding@nvidia.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).