From: Lee Jones <lee@kernel.org>
To: Benjamin Bara <bbara93@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Robin Gong <yibin.gong@nxp.com>,
Jerome Neanne <jneanne@baylibre.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-omap@vger.kernel.org,
Benjamin Bara <benjamin.bara@skidata.com>
Subject: Re: [PATCH 2/6] mfd: rk8xx: Specify restart mode
Date: Fri, 28 Jul 2023 10:59:33 +0100 [thread overview]
Message-ID: <20230728095933.GG8175@google.com> (raw)
In-Reply-To: <20230727-pca9450-reboot-v1-2-c8edb27bf404@skidata.com>
On Thu, 27 Jul 2023, Benjamin Bara wrote:
> From: Benjamin Bara <benjamin.bara@skidata.com>
>
> Specify the implemented restart handler as a cold one.
* The current implementation is an issue because ...
* If this is not fixed, the following will happen ...
* By fixing this in this way and not another way has ... advantages ...
> Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
> ---
> drivers/mfd/rk8xx-core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c
> index e8fc9e2ab1d0..15e8e6a9943a 100644
> --- a/drivers/mfd/rk8xx-core.c
> +++ b/drivers/mfd/rk8xx-core.c
> @@ -697,7 +697,8 @@ int rk8xx_probe(struct device *dev, int variant, unsigned int irq, struct regmap
> case RK809_ID:
> case RK817_ID:
> ret = devm_register_sys_off_handler(dev,
> - SYS_OFF_MODE_RESTART, SYS_OFF_PRIO_HIGH,
> + SYS_OFF_MODE_RESTART_COLD,
> + SYS_OFF_PRIO_HIGH,
> &rk808_restart, rk808);
> if (ret)
> dev_warn(dev, "failed to register rst handler, %d\n", ret);
>
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-07-28 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:26 [PATCH 0/6] regulator: pca9450: register restart handlers Benjamin Bara
2023-07-27 15:26 ` [PATCH 1/6] kernel/reboot: distinguish between cold and warm Benjamin Bara
2023-07-27 15:26 ` [PATCH 2/6] mfd: rk8xx: Specify restart mode Benjamin Bara
2023-07-28 9:59 ` Lee Jones [this message]
2023-07-27 15:26 ` [PATCH 3/6] soc/tegra: pmc: " Benjamin Bara
2023-07-27 16:53 ` Thierry Reding
2023-07-27 15:26 ` [PATCH 4/6] mfd: tps65219: " Benjamin Bara
2023-07-27 15:26 ` [PATCH 5/6] kernel/reboot: remove generic " Benjamin Bara
2023-07-27 15:26 ` [PATCH 6/6] regulator: pca9450: register restart handlers Benjamin Bara
2023-07-27 15:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728095933.GG8175@google.com \
--to=lee@kernel.org \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=broonie@kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=jneanne@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).