From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFC7C77B7F for ; Fri, 18 Aug 2023 16:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378447AbjHRQLC (ORCPT ); Fri, 18 Aug 2023 12:11:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378477AbjHRQKq (ORCPT ); Fri, 18 Aug 2023 12:10:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E4C030F3; Fri, 18 Aug 2023 09:10:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4A76611F4; Fri, 18 Aug 2023 16:10:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65662C433C8; Fri, 18 Aug 2023 16:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692375044; bh=92lIiukMG0yN5rbB/xvTrlXq9iNH0UDN9N143jJIljE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MM/dOXny8x+CcyEOHoaUyqAWJHhSHPgVPNcBHV0Sa1UKC5pu56hQIhFFaKcV+Vnry JaF6edNIABJnMqgXamZus4htecG7AquOcHbsJv4n5Pb+ZCedVtNLjLCpJpCMPK/cl8 ZozLtH6AjgCwi5O8drHX/gEyTB0YlezmY4jOM9w3V63hSIkJcNXag2Yy6jmWPHcPLL IwydNDNG79mcxxgtfefHrz/Ie3X3zWH5SeTqZP5s+gDhlH1izhuptFFF8pV/4hqvK0 fW4KPzaR86cAdAdFb+OkXyyeT96yqlPShaafpY/uRp85K5BwSiNfCKOM5/87vKvbuo 4wCpVipsFTKow== Date: Fri, 18 Aug 2023 17:10:38 +0100 From: Lee Jones To: Benjamin Bara Cc: Thierry Reding , Jonathan Hunter , Tony Lindgren , Liam Girdwood , Mark Brown , Dmitry Osipenko , peng.fan@oss.nxp.com, rafael.j.wysocki@intel.com, Jerome Neanne , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Benjamin Bara Subject: Re: [PATCH v2 4/6] mfd: tps65219: Specify restart mode Message-ID: <20230818161038.GB986605@google.com> References: <20230809-pca9450-reboot-v2-0-b98b4f8139d5@skidata.com> <20230809-pca9450-reboot-v2-4-b98b4f8139d5@skidata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230809-pca9450-reboot-v2-4-b98b4f8139d5@skidata.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, 09 Aug 2023, Benjamin Bara wrote: > From: Benjamin Bara > > The current restart handler registration does not specify whether the > restart is a cold or a warm one. Instead, cold ones are typically > registered with a HIGH prio. Now, as do_kernel_restart() knows about the > type, the priorization is implicitly done (cold restarts are executed > first) and the reboot_mode kernel parameter (which is currently mostly > ignored) can be respected. > > Signed-off-by: Benjamin Bara > --- > v2: > - improve commit message > --- > drivers/mfd/tps65219.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/mfd/tps65219.c b/drivers/mfd/tps65219.c > index 0e0c42e4fdfc..85752b93256e 100644 > --- a/drivers/mfd/tps65219.c > +++ b/drivers/mfd/tps65219.c > @@ -278,12 +278,21 @@ static int tps65219_probe(struct i2c_client *client) > } > } > > - ret = devm_register_restart_handler(tps->dev, > - tps65219_restart_handler, > - tps); > + ret = devm_register_cold_restart_handler(tps->dev, > + tps65219_restart_handler, > + tps); > > if (ret) { > - dev_err(tps->dev, "cannot register restart handler, %d\n", ret); > + dev_err(tps->dev, "cannot register cold restart handler, %d\n", ret); > + return ret; > + } > + > + ret = devm_register_warm_restart_handler(tps->dev, > + tps65219_restart_handler, > + tps); > + Sorry, why do we have to now register 2 restart handlers? Seems like a regression? > + if (ret) { > + dev_err(tps->dev, "cannot register warm restart handler, %d\n", ret); > return ret; > } > > > -- > 2.34.1 > -- Lee Jones [李琼斯]