From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E4BCE7A94 for ; Mon, 25 Sep 2023 11:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229456AbjIYLsI (ORCPT ); Mon, 25 Sep 2023 07:48:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229905AbjIYLsH (ORCPT ); Mon, 25 Sep 2023 07:48:07 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ADB3DA; Mon, 25 Sep 2023 04:48:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CD65C433C7; Mon, 25 Sep 2023 11:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695642479; bh=ayg5LSBYCOKl5a+6j88Yxa0oPYcMm7YpRHXlMokcXvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X01+Zj2ZMU+MKGstqxrUpscxFHm/e4CYLScXBUrDNhleoVE9Z7mMQqJqbSBVXDQdl OvmKv7rV+dlq+NLgUSzkq6yh3l8Uv2td1Lh0OSLPVIyd/r2gK4Gx6MoMYAj6iwOgyw mBnQzn1u8/b77rpZyHOLpy5OzRN3cqfNj1tJFPYQw/8LaxFCZEY2yydkLfHnk0B56y 5E1B3iQv3gJJ2m2EUCWLw/AXMY4NE0cPJoIlU20c4tkSBTL+Xo+vLEDX4WJiD1Xwhp DApOd1l8cHANQTlNMmEjKqa/bvVHx5WR5e3IL2cT8ICqXHw4X6yUd0gfnBD6rZzSJ5 prYRLeMEw7lgg== Date: Mon, 25 Sep 2023 19:47:48 +0800 From: Peter Chen To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: Greg Kroah-Hartman , Jonathan Hunter , Dmitry Osipenko , Peter Geis , Thierry Reding , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/3] usb: chipidea: tegra: Consistently use dev_err_probe() Message-ID: <20230925114748.GB2070044@nchen-desktop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 23-09-23 21:41:56, Michał Mirosław wrote: > Convert all error exits from probe() to dev_err_probe(). > > Signed-off-by: Michał Mirosław Acked-by: Peter Chen Peter > --- > drivers/usb/chipidea/ci_hdrc_tegra.c | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_tegra.c b/drivers/usb/chipidea/ci_hdrc_tegra.c > index 8e78bf643e25..2cc305803217 100644 > --- a/drivers/usb/chipidea/ci_hdrc_tegra.c > +++ b/drivers/usb/chipidea/ci_hdrc_tegra.c > @@ -293,14 +293,12 @@ static int tegra_usb_probe(struct platform_device *pdev) > usb->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "nvidia,phy", 0); > if (IS_ERR(usb->phy)) > return dev_err_probe(&pdev->dev, PTR_ERR(usb->phy), > - "failed to get PHY\n"); > + "failed to get PHY"); > > usb->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(usb->clk)) { > - err = PTR_ERR(usb->clk); > - dev_err(&pdev->dev, "failed to get clock: %d\n", err); > - return err; > - } > + if (IS_ERR(usb->clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(usb->clk), > + "failed to get clock"); > > err = devm_tegra_core_dev_init_opp_table_common(&pdev->dev); > if (err) > @@ -316,7 +314,7 @@ static int tegra_usb_probe(struct platform_device *pdev) > > err = tegra_usb_reset_controller(&pdev->dev); > if (err) { > - dev_err(&pdev->dev, "failed to reset controller: %d\n", err); > + dev_err_probe(&pdev->dev, err, "failed to reset controller"); > goto fail_power_off; > } > > @@ -347,8 +345,8 @@ static int tegra_usb_probe(struct platform_device *pdev) > usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource, > pdev->num_resources, &usb->data); > if (IS_ERR(usb->dev)) { > - err = PTR_ERR(usb->dev); > - dev_err(&pdev->dev, "failed to add HDRC device: %d\n", err); > + err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev), > + "failed to add HDRC device"); > goto phy_shutdown; > } > > -- > 2.39.2 > -- Thanks, Peter Chen