* [PATCH] soc/tegra: fix build failure on Tegra241
@ 2024-01-03 10:26 Arnd Bergmann
2024-01-30 11:01 ` Jon Hunter
2024-01-30 11:45 ` Kartik Rajput
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-01-03 10:26 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Kartik
Cc: Arnd Bergmann, Rob Herring, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
If all the other SoCs are disabled, the driver fails to build:
drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
684 | .read = tegra30_fuse_read,
| ^~~~~~~~~~~~~~~~~
| tegra_fuse_readl
drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
694 | .init = tegra30_fuse_init,
| ^~~~~~~~~~~~~~~~~
Fix the list of SoCs using this function to include the newly added one.
Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
index 2070d36c510d..eb14e5ff5a0a 100644
--- a/drivers/soc/tegra/fuse/fuse-tegra30.c
+++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
@@ -38,7 +38,8 @@
defined(CONFIG_ARCH_TEGRA_210_SOC) || \
defined(CONFIG_ARCH_TEGRA_186_SOC) || \
defined(CONFIG_ARCH_TEGRA_194_SOC) || \
- defined(CONFIG_ARCH_TEGRA_234_SOC)
+ defined(CONFIG_ARCH_TEGRA_234_SOC) || \
+ defined(CONFIG_ARCH_TEGRA_241_SOC)
static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
{
if (WARN_ON(!fuse->base))
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] soc/tegra: fix build failure on Tegra241
2024-01-03 10:26 [PATCH] soc/tegra: fix build failure on Tegra241 Arnd Bergmann
@ 2024-01-30 11:01 ` Jon Hunter
2024-01-30 11:45 ` Kartik Rajput
1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2024-01-30 11:01 UTC (permalink / raw)
To: Arnd Bergmann, Thierry Reding, Kartik
Cc: Arnd Bergmann, Rob Herring, linux-tegra, linux-kernel
On 03/01/2024 10:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> If all the other SoCs are disabled, the driver fails to build:
>
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
> 684 | .read = tegra30_fuse_read,
> | ^~~~~~~~~~~~~~~~~
> | tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
> 694 | .init = tegra30_fuse_init,
> | ^~~~~~~~~~~~~~~~~
>
> Fix the list of SoCs using this function to include the newly added one.
>
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
> defined(CONFIG_ARCH_TEGRA_210_SOC) || \
> defined(CONFIG_ARCH_TEGRA_186_SOC) || \
> defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> - defined(CONFIG_ARCH_TEGRA_234_SOC)
> + defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> + defined(CONFIG_ARCH_TEGRA_241_SOC)
> static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
> {
> if (WARN_ON(!fuse->base))
Thanks for fixing!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soc/tegra: fix build failure on Tegra241
2024-01-03 10:26 [PATCH] soc/tegra: fix build failure on Tegra241 Arnd Bergmann
2024-01-30 11:01 ` Jon Hunter
@ 2024-01-30 11:45 ` Kartik Rajput
1 sibling, 0 replies; 3+ messages in thread
From: Kartik Rajput @ 2024-01-30 11:45 UTC (permalink / raw)
To: Jonathan Hunter, arnd@kernel.org, thierry.reding@gmail.com
Cc: robh@kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de,
linux-tegra@vger.kernel.org
On Wed, 2024-01-03 at 11:26 +0100, Arnd Bergmann wrote:
> External email: Use caution opening links or attachments
>
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> If all the other SoCs are disabled, the driver fails to build:
>
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error:
> 'tegra30_fuse_read' undeclared here (not in a function); did you mean
> 'tegra_fuse_readl'?
> 684 | .read = tegra30_fuse_read,
> | ^~~~~~~~~~~~~~~~~
> | tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error:
> 'tegra30_fuse_init' undeclared here (not in a function); did you mean
> 'tegra_fuse_info'?
> 694 | .init = tegra30_fuse_init,
> | ^~~~~~~~~~~~~~~~~
>
> Fix the list of SoCs using this function to include the newly added
> one.
>
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c
> b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
> defined(CONFIG_ARCH_TEGRA_210_SOC) || \
> defined(CONFIG_ARCH_TEGRA_186_SOC) || \
> defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> - defined(CONFIG_ARCH_TEGRA_234_SOC)
> + defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> + defined(CONFIG_ARCH_TEGRA_241_SOC)
> static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned
> int offset)
> {
> if (WARN_ON(!fuse->base))
> --
> 2.39.2
>
Thanks Arnd!
Reviewed-by: Kartik <kkartik@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-30 11:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-03 10:26 [PATCH] soc/tegra: fix build failure on Tegra241 Arnd Bergmann
2024-01-30 11:01 ` Jon Hunter
2024-01-30 11:45 ` Kartik Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox