From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21FE7535BA for ; Fri, 8 Mar 2024 09:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891407; cv=none; b=WszwHooo8/q/Sgz4JT1jlSZvrQy5We0qhpHqRIDM6i9LBHzMqYsyVqL6BOIcHmzHfjHfI/zGxyEZLHS3/uxdMl9b3IZ2KU6F2q8cjZ+yzXv//ygE0IHJOTHmPjFnZ4+dQSFh0EzqrsHR669H0urGdkhH2kwTpy5teU87mSvaDkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709891407; c=relaxed/simple; bh=N+FnD75U9P5fcQ38HlMO4pcD/DzIJlqTaauzTbsehwI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sp4Hflh1XXwuketxGSbofYqZpuSMVH32HXzn1IDHQSo6bYiV0VgTFcPyu5KZygFYx1bEl0R9DC2LFi7RC4cyDyz8EwFrk/gLoPXwy+a76VyqZgxfziPENudy+wtKPJsEoPBegDY+9BHbEtQZW3P8ItGnH2kqs/z/Ncq94JYIy1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HDUwHABd; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HDUwHABd" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso1523782a12.0 for ; Fri, 08 Mar 2024 01:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709891405; x=1710496205; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=HDUwHABdT92cmTAErIymd71gIzFwxlngdnjYnnJDu5wUhDIg1nJK4RHjEo4BS0jKuB G99mFpPQfLPiXRRmEYZJDp2kreUmiWDm9R94GfowCB8JSfRVXY/vnKddRLtk8N67lqxu fePNWztxa8g5MNRwH2cxR97zdVlikMFyNII48E6VE6zZr0xkdfANfTA5y+GPT+QZVVDr ScS4ME+JQyD1CYdFB31P8uecrdFfh/L4t2a6g+sw/vUJxDXIYuvM3OUXmE1K47WLZvY6 1ibvW+/j9gbUHU4aPBtNNaTmQxXVENs4Mt4GwBC1zu5fQyAMM1uYwDlX/8GvgnNIU2f4 Gq2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709891405; x=1710496205; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+dKXhomeB6Ij6pEZAsrhigScw7Imo0KcKY8tqU3ajKw=; b=UzBrWRWDwAuj7Zcxt4FdlhGiuV+Q8Ex0Rx0v9e39wL7FjDZMtWPsliQEJ7joM7UigL coVgORBkyhvNZOjaacboxnF08XtXoOmF1R+CTKSp6nX6uH5hNTadw1oCAjdpOlXNGnM9 KSaOmqh87q5UL0p64wvUH71yLPIATgjr8Ev7RZAq3i57cbDqqnBkKLFuDeVvXlJq9ltJ JF5mv9tc26UFluj0Q1vLk5NN55bXVP0CycHOnG/pbf0gy0YQL3j6zZdQWqqLSx56/bGv 56MNMAwbt+WMB6cef55QP0yu7tXU4AD57h0H44qqZVqitCPvnIn0LDyKBDB1EucKT0Ce YcfQ== X-Forwarded-Encrypted: i=1; AJvYcCUycdLZu8rhUjZEEMXF2gpa/YA1+ipG+AhP9gzLt+9c8Bp//Rr4+D/0qqX7C0wJzR3QzxOKlmjAirHNYm6t7M9NpS2n10H3Ws0J6iY= X-Gm-Message-State: AOJu0Yz6ANbVEq9W1lFObto6S9TGZ37E6A20b2xPqc60NZTDa312hj9s m70oVkbtUyuYJYB3ywK/pMUK/WD94rqeY6Rvt5xX2rdb6FcOJxjfbTIrBu0uyg== X-Google-Smtp-Source: AGHT+IEMW10NsMpl6QbbrMpGgV+z8bvUPkiIHa5C3nopapJCs9aJNBuwrvqex+LlxA53iZxgm5hkkg== X-Received: by 2002:a05:6a20:160a:b0:1a1:4a45:c05f with SMTP id l10-20020a056a20160a00b001a14a45c05fmr12756809pzj.25.1709891405150; Fri, 08 Mar 2024 01:50:05 -0800 (PST) Received: from thinkpad ([117.217.183.232]) by smtp.gmail.com with ESMTPSA id w8-20020a17090aea0800b0029bb8ebdc23sm374544pjy.37.2024.03.08.01.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 01:50:04 -0800 (PST) Date: Fri, 8 Mar 2024 15:19:47 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com Subject: Re: [PATCH v9 06/10] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers Message-ID: <20240308094947.GH3789@thinkpad> References: <20240304-pci-dbi-rework-v9-0-29d433d99cda@linaro.org> <20240304-pci-dbi-rework-v9-6-29d433d99cda@linaro.org> <20240308053624.GB3789@thinkpad> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 08, 2024 at 10:05:11AM +0100, Niklas Cassel wrote: > On Fri, Mar 08, 2024 at 11:06:24AM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 09:36:56PM +0100, Niklas Cassel wrote: > > > On Mon, Mar 04, 2024 at 02:52:18PM +0530, Manivannan Sadhasivam wrote: > > > > Currently, dw_pcie_ep_init_registers() API is directly called by the glue > > > > drivers requiring active refclk from host. But for the other drivers, it is > > > > getting called implicitly by dw_pcie_ep_init(). This is due to the fact > > > > that this API initializes DWC EP specific registers and that requires an > > > > active refclk (either from host or generated locally by endpoint itsef). > > > > > > > > But, this causes a discrepancy among the glue drivers. So to avoid this > > > > confusion, let's call this API directly from all glue drivers irrespective > > > > of refclk dependency. Only difference here is that the drivers requiring > > > > refclk from host will call this API only after the refclk is received and > > > > other drivers without refclk dependency will call this API right after > > > > dw_pcie_ep_init(). > > > > > > > > With this change, the check for 'core_init_notifier' flag can now be > > > > dropped from dw_pcie_ep_init() API. This will also allow us to remove the > > > > 'core_init_notifier' flag completely in the later commits. > > > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > --- > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pci-imx6.c | 8 ++++++++ > > > > drivers/pci/controller/dwc/pci-keystone.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 7 +++++++ > > > > drivers/pci/controller/dwc/pcie-artpec6.c | 13 ++++++++++++- > > > > drivers/pci/controller/dwc/pcie-designware-ep.c | 22 ---------------------- > > > > drivers/pci/controller/dwc/pcie-designware-plat.c | 9 +++++++++ > > > > drivers/pci/controller/dwc/pcie-keembay.c | 16 +++++++++++++++- > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +++++++++++- > > > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 13 ++++++++++++- > > > > 10 files changed, 90 insertions(+), 26 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > > > > index 0e406677060d..395042b29ffc 100644 > > > > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > > > > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > > > > @@ -467,6 +467,13 @@ static int dra7xx_add_pcie_ep(struct dra7xx_pcie *dra7xx, > > > > return ret; > > > > } > > > > > > > > + ret = dw_pcie_ep_init_registers(ep); > > > > + if (ret) { > > > > > > Here you are using if (ret) to error check the return from > > > dw_pcie_ep_init_registers(). > > > > > > > > > > index c0c62533a3f1..8392894ed286 100644 > > > > --- a/drivers/pci/controller/dwc/pci-keystone.c > > > > +++ b/drivers/pci/controller/dwc/pci-keystone.c > > > > @@ -1286,6 +1286,13 @@ static int ks_pcie_probe(struct platform_device *pdev) > > > > ret = dw_pcie_ep_init(&pci->ep); > > > > if (ret < 0) > > > > goto err_get_sync; > > > > + > > > > + ret = dw_pcie_ep_init_registers(&pci->ep); > > > > + if (ret < 0) { > > > > > > Here you are using if (ret < 0) to error check the return from > > > dw_pcie_ep_init_registers(). Please be consistent. > > > > > > > I maintained the consistency w.r.t individual drivers. Please check them > > individually. > > > > If I maintain consistency w.r.t this patch, then the style will change within > > the drivers. > > Personally, I disagree with that. > > All glue drivers should use the same way of checking dw_pcie_ep_init(), > depending on the kdoc of dw_pcie_ep_init(). > > If the kdoc for dw_pcie_ep_init() says returns 0 on success, > then I think that it is strictly more correct to do: > > ret = dw_pcie_ep_init() > if (ret) { > > } > > And if a glue driver doesn't look like that, then I think we should change > them. (Same reasoning for dw_pcie_ep_init_registers().) > > > If you read code that looks like: > ret = dw_pcie_ep_init() > if (ret < 0) { > > } > > then you assume that is is a function with a kdoc that says it can return 0 > or a positive value on success, e.g. a function that returns an index in an > array. > But if you read the same function from the individual drivers, it could present a different opinion because the samantics is different than others. I'm not opposed to keeping the API semantics consistent, but we have to take account of the drivers style as well. - Mani -- மணிவண்ணன் சதாசிவம்