[PATCH 0/3] Dead structs in media/platform

[PATCH 0/3] Dead structs in media/platform

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

Clean out a bunch of dead structs in media/platform.
Build tested only.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Dr. David Alan Gilbert (3):
  meida: amphion: remove unused struct 'vpu_malone_frame_buffer'
  media: m2m-deinterlace: remove unused struct 'vb2_dc_conf'
  media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

 drivers/media/platform/amphion/vpu_malone.c    | 5 -----
 drivers/media/platform/m2m-deinterlace.c       | 4 ----
 drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
 3 files changed, 14 deletions(-)

-- 
2.45.1

[PATCH 1/3] meida: amphion: remove unused struct 'vpu_malone_frame_buffer'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'vpu_malone_frame_buffer' has been unused since the original
commit 145e936380ed ("media: amphion: implement malone decoder rpc
interface").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/media/platform/amphion/vpu_malone.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/media/platform/amphion/vpu_malone.c b/drivers/media/platform/amphion/vpu_malone.c
index d3425de7bccd..4769c053c6c2 100644
--- a/drivers/media/platform/amphion/vpu_malone.c
+++ b/drivers/media/platform/amphion/vpu_malone.c
@@ -207,11 +207,6 @@ struct vpu_malone_dbglog_desc {
 	u32 reserved;
 };
 
-struct vpu_malone_frame_buffer {
-	u32 addr;
-	u32 size;
-};
-
 struct vpu_malone_udata {
 	u32 base;
 	u32 total_size;
-- 
2.45.1

[PATCH 2/3] media: m2m-deinterlace: remove unused struct 'vb2_dc_conf'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'vb2_dc_conf' has been unused since the original
commit 8f0755c06b90 ("[media] media: Add mem2mem deinterlacing driver").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/media/platform/m2m-deinterlace.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c
index 96b35a5d6174..5adcef80c698 100644
--- a/drivers/media/platform/m2m-deinterlace.c
+++ b/drivers/media/platform/m2m-deinterlace.c
@@ -724,10 +724,6 @@ static const struct v4l2_ioctl_ops deinterlace_ioctl_ops = {
 /*
  * Queue operations
  */
-struct vb2_dc_conf {
-	struct device           *dev;
-};
-
 static int deinterlace_queue_setup(struct vb2_queue *vq,
 				unsigned int *nbuffers, unsigned int *nplanes,
 				unsigned int sizes[], struct device *alloc_devs[])
-- 
2.45.1

[PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'tegra_vde_h264_frame' has been unused since
commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
support").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
index cfea5572a1b8..d8812fc06c67 100644
--- a/drivers/media/platform/nvidia/tegra-vde/h264.c
+++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
@@ -19,11 +19,6 @@
 #define FLAG_B_FRAME		0x1
 #define FLAG_REFERENCE		0x2
 
-struct tegra_vde_h264_frame {
-	unsigned int frame_num;
-	unsigned int flags;
-};
-
 struct tegra_vde_h264_decoder_ctx {
 	unsigned int dpb_frames_nb;
 	unsigned int dpb_ref_frames_with_earlier_poc_nb;
-- 
2.45.1

Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

[Hans Verkuil]

On 25/05/2024 02:01, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'tegra_vde_h264_frame' has been unused since
> commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> support").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
> index cfea5572a1b8..d8812fc06c67 100644
> --- a/drivers/media/platform/nvidia/tegra-vde/h264.c
> +++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
> @@ -19,11 +19,6 @@
>  #define FLAG_B_FRAME		0x1
>  #define FLAG_REFERENCE		0x2
>  
> -struct tegra_vde_h264_frame {
> -	unsigned int frame_num;
> -	unsigned int flags;
> -};
> -
>  struct tegra_vde_h264_decoder_ctx {
>  	unsigned int dpb_frames_nb;
>  	unsigned int dpb_ref_frames_with_earlier_poc_nb;

There is one more reference to this, that also can be dropped:

$ git grep tegra_vde_h264_frame
drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;

Regards,

	Hans

Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

[Dr. David Alan Gilbert]

* Hans Verkuil (hverkuil@xs4all.nl) wrote:
> On 25/05/2024 02:01, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > 'tegra_vde_h264_frame' has been unused since
> > commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> > support").
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > index cfea5572a1b8..d8812fc06c67 100644
> > --- a/drivers/media/platform/nvidia/tegra-vde/h264.c
> > +++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > @@ -19,11 +19,6 @@
> >  #define FLAG_B_FRAME		0x1
> >  #define FLAG_REFERENCE		0x2
> >  
> > -struct tegra_vde_h264_frame {
> > -	unsigned int frame_num;
> > -	unsigned int flags;
> > -};
> > -
> >  struct tegra_vde_h264_decoder_ctx {
> >  	unsigned int dpb_frames_nb;
> >  	unsigned int dpb_ref_frames_with_earlier_poc_nb;
> 
> There is one more reference to this, that also can be dropped:
> 
> $ git grep tegra_vde_h264_frame
> drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;

Thanks! v2 just sent (where I also fixed a typo in the first patch
in the series's title).

Dave

> Regards,
> 
> 	Hans
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/