From: Christoph Hellwig <hch@lst.de>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Jon Hunter <jonathanh@nvidia.com>, Jens Axboe <axboe@kernel.dk>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: Fix max_seg_size for 64KiB PAGE_SIZE
Date: Thu, 11 Jul 2024 08:48:03 +0200 [thread overview]
Message-ID: <20240711064803.GA6313@lst.de> (raw)
In-Reply-To: <44a4c774-c312-48d7-a627-19a7b86a3bf5@intel.com>
On Thu, Jul 11, 2024 at 08:17:47AM +0300, Adrian Hunter wrote:
> On 11/07/24 07:01, Christoph Hellwig wrote:
> > On Wed, Jul 10, 2024 at 09:07:37PM +0300, Adrian Hunter wrote:
> >> blk_queue_max_segment_size() ensured:
> >>
> >> if (max_size < PAGE_SIZE)
> >> max_size = PAGE_SIZE;
> >
> > This is a bit misleading, as it also warned about it and papered over it
> > with the above as it had no way to return errors. Any everyone seeing
> > these problems now ignored the warnings before, probably for years..
>
> Was there a warning, since the message in blk_queue_max_segment_size()
> was:
>
> pr_info("%s: set to minimum %u\n", __func__, max_size);
It stated out as a plain printk and became an info later, but yes,
not the big warning sign it was supposed to be.
next prev parent reply other threads:[~2024-07-11 6:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 18:07 [PATCH] mmc: sdhci: Fix max_seg_size for 64KiB PAGE_SIZE Adrian Hunter
2024-07-11 4:01 ` Christoph Hellwig
2024-07-11 5:17 ` Adrian Hunter
2024-07-11 6:48 ` Christoph Hellwig [this message]
2024-07-11 9:47 ` Jon Hunter
2024-07-11 16:03 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711064803.GA6313@lst.de \
--to=hch@lst.de \
--cc=adrian.hunter@intel.com \
--cc=axboe@kernel.dk \
--cc=jonathanh@nvidia.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox