From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FAD72D030 for ; Wed, 24 Jul 2024 13:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721828857; cv=none; b=UcRMfHM4qm2Tym06/uEDemYYTz5qI9mpSPIeJDNcPPA1bZiIHg26EPfclGB9ei0S1AHeOjzxTBJDr3QcsVXSTFPs/OHhmKgBwLaHYrKKTN/K8sx+HoRNy4qytdZ51k2PL/F5KW6P6Z7tVK+Aj1kJTxZIaGoZvT4nZrYzR89/UPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721828857; c=relaxed/simple; bh=xjWm/eDlWeqPzKSEQS2S0Ya+3sWJ6iqZgAKGHCaMITE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jBJwoFfGm+KLPSo5Me7j7vTAOqGMLYE1AuwI6e3813QXttanQr4LaC9WhqOxSH7sGvwh/8ETlBnGB2otLeogSD18xztsnTw7heUI3R5ISn4FyJG8FSXNC0WmU2ssPbf4SpRowxA9XEBp9Ml/XY5srzTVwg1jvZf8qj1y6fm1Cy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h7tkJN0I; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h7tkJN0I" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1fc569440e1so17108435ad.3 for ; Wed, 24 Jul 2024 06:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721828854; x=1722433654; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SjlS3KeN9meLLfSQsSaPi/f/kHzcBW78TFSUcPryCjM=; b=h7tkJN0IXAmZSDVDgQOpeqfw+8fvEIc3K1Sbftr9/y0yr79iR+NCNt33saVsG1zH+Z fMBSAvmZ+HthOyrGq/J8fiQhuggVeJDZkNx9dZMRxXMSLDVYyn8Rw/h5Sef+QszH30Lg 6K4XgaDxEe8PlovPdua7+GVEx0iaBo7NRBdqS6ShNyG1ngwkSWKAjmSy2VgKlg/jIXEz iWM8hn0W6YrN13X5Zgp//JjFslD0GJK3urRYc+pxE+MjAMPv9sDFvhsReSodr4HZO6iL dejcqC8zG9pVucrHnWh1Ejy/FlWkKhe/eaXgMkQioAxsZqCTlkk6V9EMCxX2HfKp97b1 L6Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721828854; x=1722433654; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SjlS3KeN9meLLfSQsSaPi/f/kHzcBW78TFSUcPryCjM=; b=bP0qywYdaVeiUMYM9KbK2MKPWeaRMHRhIi2yLdaMx45aMdItDtuUkFfcJgbDdyCnlP /1r0jpYfRueeaW3AwRJ4nMrw5hhh/MeqQs9IuAl9yq1rkhLXKB+dXlRBNl6uj7hwbM2G whVv+JkiTx7YPs93iy2h3FfGZmBQXSAQD4grSPbTAyECmwSFDlAVOPYAifoghmuxa4Zh xgl2sy5CvqphSpn1VnsbIp1yFxuzyLs7YKUkqnEZ/PRZznOoLppN+UGUBZ4jCHQpUuH4 h3XBjtporLIxSvbgYjo4RrCAc61lqhJEEB8plzhM+P8k3SlUijHjjpgad4NaEtajYqFO uj1A== X-Forwarded-Encrypted: i=1; AJvYcCXiNMGYAzzzAdUWfX9ijlxi01rBmoPkuEck+LzZcsTOOZgIvJcIJJWOcVgngNyR6Xab5Yg1BZSh4U2pq0hsKjGgHG+fOWg3pVjGglU= X-Gm-Message-State: AOJu0YwdtgiorQOkckFf98hN5BWi5q7asUIsY/588mQDaKyYrxqZi1AQ JG3I8kq0uI5ApaZjc9Ul29UEGG0WgQ99/+fHwxrkjXzgiLlsUk6PHHjqJaYN+A== X-Google-Smtp-Source: AGHT+IGQ1pRozmQ8WsiHI1I3zmEDTN6hvlFln3KcelbKxSnwPg41LAbjogxZsXYR2+UZUvCxUcYACA== X-Received: by 2002:a17:903:244a:b0:1fc:2ee3:d45a with SMTP id d9443c01a7336-1fdd54f46f3mr24825785ad.8.1721828853831; Wed, 24 Jul 2024 06:47:33 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f44f4c4sm94151845ad.224.2024.07.24.06.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 06:47:33 -0700 (PDT) Date: Wed, 24 Jul 2024 19:17:21 +0530 From: Manivannan Sadhasivam To: Marek Vasut Cc: linux-pci@vger.kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Pali =?iso-8859-1?Q?Roh=E1r?= , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Nirmal Patel , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 05/15] PCI: dwc: Silence set affinity failed warning Message-ID: <20240724134721.GC3349@thinkpad> References: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> <20240723132958.41320-6-marek.vasut+renesas@mailbox.org> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240723132958.41320-6-marek.vasut+renesas@mailbox.org> On Tue, Jul 23, 2024 at 03:27:05PM +0200, Marek Vasut wrote: > Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset > and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without > printing "IRQ...: set affinity failed(-22)" warning. > > Remove .irq_set_affinity implementation which only return -EINVAL from this > controller driver. > > Signed-off-by: Marek Vasut Reviewed-by: Manivannan Sadhasivam - Mani > --- > Cc: "Krzysztof Wilczyński" > Cc: "Pali Rohár" > Cc: "Uwe Kleine-König" > Cc: Aleksandr Mishin > Cc: Anna-Maria Behnsen > Cc: Anup Patel > Cc: Bjorn Helgaas > Cc: Broadcom internal kernel review list > Cc: Daire McNamara > Cc: Damien Le Moal > Cc: Florian Fainelli > Cc: Hou Zhiqiang > Cc: Jianjun Wang > Cc: Jim Quinlan > Cc: Jingoo Han > Cc: Jisheng Zhang > Cc: Jon Hunter > Cc: Jonathan Derrick > Cc: Jonathan Hunter > Cc: Joyce Ooi > Cc: Karthikeyan Mitran > Cc: Kishon Vijay Abraham I > Cc: Koichiro Den > Cc: Lorenzo Pieralisi > Cc: Manivannan Sadhasivam > Cc: Marc Zyngier > Cc: Michal Simek > Cc: Nicolas Saenz Julienne > Cc: Niklas Cassel > Cc: Nipun Gupta > Cc: Nirmal Patel > Cc: Rob Herring > Cc: Ryder Lee > Cc: Shivamurthy Shastri > Cc: Siddharth Vadapalli > Cc: Thierry Reding > Cc: Thomas Gleixner > Cc: Thomas Petazzoni > Cc: Yoshihiro Shimoda > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-pci@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > --- > V4: - New patch > --- > drivers/pci/controller/dwc/pci-keystone.c | 7 ------- > drivers/pci/controller/dwc/pcie-designware-host.c | 12 +++--------- > 2 files changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > index 52c6420ae2003..ce9d9e0a52609 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -189,12 +189,6 @@ static void ks_pcie_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) > (int)data->hwirq, msg->address_hi, msg->address_lo); > } > > -static int ks_pcie_msi_set_affinity(struct irq_data *irq_data, > - const struct cpumask *mask, bool force) > -{ > - return -EINVAL; > -} > - > static void ks_pcie_msi_mask(struct irq_data *data) > { > struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(data); > @@ -247,7 +241,6 @@ static struct irq_chip ks_pcie_msi_irq_chip = { > .name = "KEYSTONE-PCI-MSI", > .irq_ack = ks_pcie_msi_irq_ack, > .irq_compose_msi_msg = ks_pcie_compose_msi_msg, > - .irq_set_affinity = ks_pcie_msi_set_affinity, > .irq_mask = ks_pcie_msi_mask, > .irq_unmask = ks_pcie_msi_unmask, > }; > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index a0822d5371bc5..3e41865c72904 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -48,8 +48,9 @@ static struct irq_chip dw_pcie_msi_irq_chip = { > }; > > static struct msi_domain_info dw_pcie_msi_domain_info = { > - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI), > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX | > + MSI_FLAG_MULTI_PCI_MSI, > .chip = &dw_pcie_msi_irq_chip, > }; > > @@ -116,12 +117,6 @@ static void dw_pci_setup_msi_msg(struct irq_data *d, struct msi_msg *msg) > (int)d->hwirq, msg->address_hi, msg->address_lo); > } > > -static int dw_pci_msi_set_affinity(struct irq_data *d, > - const struct cpumask *mask, bool force) > -{ > - return -EINVAL; > -} > - > static void dw_pci_bottom_mask(struct irq_data *d) > { > struct dw_pcie_rp *pp = irq_data_get_irq_chip_data(d); > @@ -177,7 +172,6 @@ static struct irq_chip dw_pci_msi_bottom_irq_chip = { > .name = "DWPCI-MSI", > .irq_ack = dw_pci_bottom_ack, > .irq_compose_msi_msg = dw_pci_setup_msi_msg, > - .irq_set_affinity = dw_pci_msi_set_affinity, > .irq_mask = dw_pci_bottom_mask, > .irq_unmask = dw_pci_bottom_unmask, > }; > -- > 2.43.0 > -- மணிவண்ணன் சதாசிவம்