From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0202014D293; Wed, 24 Jul 2024 15:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835797; cv=none; b=l7HnRuL1hC6HsgMdhnKWZkE66hCmrbqDzlajAxvz6R+b4oEIFIsoSObgZiCFtuT/pZBEcTLhfIjwgQKTPI+U7ESRcoxxUatiy0c6HlTFG+YS5Kcuu73p9hBvpAV+Wmo4KY0/wrbBg+1mQGPHPWcu1Hw/vPnhgPISQDBaGI6EuJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721835797; c=relaxed/simple; bh=CAUscHClM0Mm+A7tgR9qonZKiiwkl9RkhG3FCitYr3g=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=EifzuOBAaXgRNm0cPFtZC/I8ubuTceLhTQOkC9TmG5RC0auom3z9zxkGhNIrLyGjUbZFSISYB2HR9FeLnJFugYnf/jsjUYJ3Z0swwuLRTlILQpU7pXEBvTNFh9eWUj7usPgR2WSqrwMP83uvHwKPX2hrIt+OKWVDJmqCUBZFcu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Lgs+a+Gj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lgs+a+Gj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37506C32782; Wed, 24 Jul 2024 15:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721835796; bh=CAUscHClM0Mm+A7tgR9qonZKiiwkl9RkhG3FCitYr3g=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Lgs+a+Gj8Z6SEL3m6Ih6tZ1yAEtVhA0Gd0o9Nsgm6NY39oGgx2+lpT3+puUYV4ewx 0VncHfOrm5ibiNkfpvfo4yOl14RmuPzrNvBWdCx/gYYwj/FxpG1XnbyqvIZqZGfgrN QICGF1WW5OhI/rnZx6IhUVs4ZxBDXhXxR/nZcEVWx96Cmq75t+POuM7nvub19/S+Sj mH87+JNrMabZAJAFNC3dHn2JV/0eAtwNjddtwjn3Xh/nFi/07VgNCKZNnvtIM4v+6W 1Wj8vFKn2VuaUF8nTLSDOam4hSFiSDlKJfz0KaTxGzV39mi35OtigfkFFSUsBDXg9n 6YaXj3FJjAjCQ== Date: Wed, 24 Jul 2024 10:43:14 -0500 From: Bjorn Helgaas To: Marek Vasut Cc: linux-pci@vger.kernel.org, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Pali =?utf-8?B?Um9ow6Fy?= , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Manivannan Sadhasivam , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Nirmal Patel , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v4 00/15] genirq/msi: Silence set affinity failed warning Message-ID: <20240724154314.GA800620@bhelgaas> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> On Tue, Jul 23, 2024 at 03:27:00PM +0200, Marek Vasut wrote: > Various PCIe controllers that mux MSIs onto single IRQ line produce these > "IRQ%d: set affinity failed" warnings when entering suspend. Remove the > .irq_set_affinity callbacks and make sure they are NULL in all affected > controllers, so this warning in kernel/irq/msi.c is not triggered. > > This has been compile-tested only on all but the R-Car PCI controller. > > The clean ups are done per-driver so they can be easily reverted in case > they break something. > > Marek Vasut (15): > genirq/msi: Silence set affinity failed warning > PCI: aardvark: Silence set affinity failed warning > PCI: altera-msi: Silence set affinity failed warning > PCI: brcmstb: Silence set affinity failed warning > PCI: dwc: Silence set affinity failed warning > PCI: mediatek-gen3: Silence set affinity failed warning > PCI: mediatek: Silence set affinity failed warning > PCI: mobiveil: Silence set affinity failed warning > PCI: plda: Silence set affinity failed warning > PCI: rcar-host: Silence set affinity failed warning > PCI: tegra: Silence set affinity failed warning > PCI: vmd: Silence set affinity failed warning > PCI: xilinx-nwl: Silence set affinity failed warning > PCI: xilinx-xdma: Silence set affinity failed warning > PCI: xilinx: Silence set affinity failed warning Happy to apply this series via the PCI tree given an ack from Thomas. In that event I would rewrap the commit logs to fit in 75 columns and include a note in the driver patches about what event causes the warning. No need to repost for that unless other changes are needed. Thanks for doing this work! Bjorn