Re: [PATCH v3 2/3] clocksource/drivers/timer-tegra186: fix watchdog self-pinging

Thierry Reding
2025-04-10T10:15:53Z

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

On Mon, Apr 07, 2025 at 06:23:22PM +0800, Robert Lin wrote:
> From: Pohsun Su <pohsuns@nvidia.com>
>
> This change removes watchdog self-pinging behavior.
>
> The timer irq handler is triggered due to the 1st expiration,
> the handler disables and enables watchdog but also implicitly
> clears the expiration count so the count can only be 0 or 1.
>
> Since this watchdog supports opened, configured, or pinged by
> systemd, We remove this behavior or the watchdog may not bark
> when systemd crashes since the 5th expiration never comes.
>
> Signed-off-by: Pohsun Su <pohsuns@nvidia.com>
> Signed-off-by: Robert Lin <robelin@nvidia.com>
> ---
> drivers/clocksource/timer-tegra186.c | 24 ------------------------
> 1 file changed, 24 deletions(-)

Yeah, in retrospect this doesn't make sense:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]