From: Conor Dooley <conor.dooley@microchip.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Conor Dooley <conor@kernel.org>, Vishwaroop A <va@nvidia.com>,
<krzk@kernel.org>, <broonie@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<thierry.reding@gmail.com>, <skomatineni@nvidia.com>,
<ldewangan@nvidia.com>, <kyarlagadda@nvidia.com>,
<smangipudi@nvidia.com>, <bgriffis@nvidia.com>,
<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 RESEND 1/2] dt-bindings: spi: tegra: Document IOMMU property for Tegra234 QSPI
Date: Tue, 13 May 2025 11:59:38 +0100 [thread overview]
Message-ID: <20250513-implode-half-0c3ffcf6d3f5@wendy> (raw)
In-Reply-To: <904d3e89-a540-4edd-b748-15e13c431c17@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
On Tue, May 13, 2025 at 11:19:05AM +0100, Jon Hunter wrote:
> > > + - $ref: spi-controller.yaml#
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + const: nvidia,tegra234-qspi
> >
> > > + then:
> > > + properties:
> > > + iommus: true
> >
> > This is a NOP, no?
> > Just invert the case above and drop a clause.
>
>
> Yes that's true. So just to confirm, your preference is this ...
>
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> index 04d3b1a47392..c45511e9a9ed 100644
> --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> @@ -74,11 +74,13 @@ allOf:
> - if:
> properties:
> compatible:
> - const: nvidia,tegra234-qspi
> + contains:
> + enum:
> + - nvidia,tegra210-qspi
> + - nvidia,tegra186-qspi
> + - nvidia,tegra194-qspi
> + - nvidia,tegra241-qspi
> then:
> - properties:
> - iommus: true
> - else:
> properties:
> iommus: false
You can just invert the condition directly with a not:,
so "if: properties: compatible: not: contains:" should do the trick.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-05-13 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 16:54 [PATCH V3 RESEND 1/2] dt-bindings: spi: tegra: Document IOMMU property for Tegra234 QSPI Vishwaroop A
2025-05-09 16:54 ` [PATCH V3 RESEND 2/2] spi: tegra210-quad: Add support for internal DMA Vishwaroop A
2025-05-12 16:49 ` [PATCH V3 RESEND 1/2] dt-bindings: spi: tegra: Document IOMMU property for Tegra234 QSPI Conor Dooley
2025-05-13 10:19 ` Jon Hunter
2025-05-13 10:59 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513-implode-half-0c3ffcf6d3f5@wendy \
--to=conor.dooley@microchip.com \
--cc=bgriffis@nvidia.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=va@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).