From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0899A193402; Wed, 14 May 2025 19:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747251088; cv=none; b=uDubgM14kUFeAZaLlmSwup/f2LtCNCd3+cLxXFOkW+8HuY8POhqfGjNlbsGFAbgArIH9duy3AV6XPNlFUUu03JCcU8tl92prz4xyGIL0PiczfzTeSrcZVElffv63r3/Cz7tnJOTPq7KGTUNvcZzSB38oK0UjpMZQwg1U2lPPz6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747251088; c=relaxed/simple; bh=prqn5Sx99GKjaup3K45kEwrx2MjZ0zoK5fYZeZeYwLA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=foxbKw9p80QC0q/w15n31QSFnae6HKeuLgFJHBlLhUWbnyNikNzSPGs8+DLJwBiZtfOs6pVMS2F1TjlACDwZ8Xyb62/VvyGsJxdTqxQg1Ot3Y3QDEZEWU//gU8vWPJJ565qHJmZvOYYPGoNg3aYV/p53X6sedCE86aULJwhpiv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TCAqMPUK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TCAqMPUK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D6BBC4CEE3; Wed, 14 May 2025 19:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747251087; bh=prqn5Sx99GKjaup3K45kEwrx2MjZ0zoK5fYZeZeYwLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TCAqMPUKzRjQlVOpZ/5t8utZHHoRuBzqN48mWTHKv/Hql3kfalT1IP2AqIMb08wuw aFeoNjI156ewl1VP+NztGIRAZbBI8tDQ5reQA3Up4TD5bjLCVVg3y3T0u7B7WHbwdR M+ffnoViS1+8krR3rL54F5xiGyPdhOoDi7IYjzs0wGKhrymm1edipYq0OprVbK+Tfi KpHGgd21AN8EKuDeo27vK9/7CZ+5TYXF+RUbMG8FI3SV+yGYTxGJgSzPq5IBa6HRGK x71PcqLHusY4fBjcek1ZBdFVTyi+M6oxdtexi5RpEQ5Aex2Rg8F575I54UqEBdoYuH BMHhMI2aa6ymg== Date: Wed, 14 May 2025 14:31:25 -0500 From: Rob Herring To: Thierry Reding Cc: Krzysztof Kozlowski , Jon Hunter , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/8] dt-bindings: memory: Add Tegra264 definitions Message-ID: <20250514193125.GA2845766-robh@kernel.org> References: <20250507143802.1230919-1-thierry.reding@gmail.com> <20250507143802.1230919-6-thierry.reding@gmail.com> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 08, 2025 at 11:09:12AM +0200, Thierry Reding wrote: > On Thu, May 08, 2025 at 10:45:29AM +0200, Krzysztof Kozlowski wrote: > > On 08/05/2025 10:02, Thierry Reding wrote: > > >> > > >> > > >>> how much more you'd like me to make it based on that. Do you expect me > > >>> to add the nvidia, prefix? In that case it would be inconsistent with > > >>> all of the 8 other Tegra MC includes that we have in that directory. > > >> > > >> > > >> Same story as for every other case, why this would be different? All of > > >> them - amlogic, mediatek, samsung, qcom, every soc - move to new style > > >> since some years, why this one should be different? > > > > > > Because we've used exactly this naming convention for more than a > > > decade. I get that it's nice to have consistency, but do you really want > > > me to go and churn all of these files just so we can add a vendor-prefix > > > and drop a redundant suffix? > > No, I want new files. Look: > > 1. Some time ago tegra-1.h was added. > > 2. Someone spotted that there was tegra-1.h, so added now tegra-2.h. > > 3. Now this is a pattern so of course next person, even if asked to use > > vendor prefix, will not, right? Because it would break the pattern. So > > we have tegra-3.h > > 4. tegra.4 - no vendor prefix, because you have already three cases. > > 5. You see where I am going? > > > > All of above - amlogic, mediatek, samsung, qcom - had decade of such > > convention. I asked to changed, they used the same argument as you > > ("decade") and then changed. > > > > Why this is different case than decade in amlogic, mediatek, samsung and > > qcom? > > It's a matter of principle. One convention is as good as another. There > are no clear advantages of one over another. It's pointless and frankly > there are more important things than changing filenames that everybody > has been okay with for the last 10 years. The issue is one convention is consistent for you and only you, the other is consistent for *everyone*. And then we'll have someone argue they are just following the same convention as Tegra... If you had several drivers and add a new one, would you argue that the new one should follow the conventions of the old drivers rather than current conventions? No, you wouldn't. Rob