Re: [PATCH v3 4/6] dt-bindings: thermal: tegra: add Tegra114 soctherm header

Svyatoslav Ryhel
2025-08-21T06:46:01Z

чт, 21 серп. 2025 р. о 09:39 Mikko Perttunen <mperttunen@nvidia.com> пише:
>
> On Wednesday, August 20, 2025 8:42 PM Svyatoslav Ryhel wrote:
> > This adds header for the Tegra114 SOCTHERM device tree node.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> > .../dt-bindings/thermal/tegra114-soctherm.h | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> > create mode 100644 include/dt-bindings/thermal/tegra114-soctherm.h
> >
> > diff --git a/include/dt-bindings/thermal/tegra114-soctherm.h
> > b/include/dt-bindings/thermal/tegra114-soctherm.h new file mode 100644
> > index 000000000000..b605e53284fe
> > --- /dev/null
> > +++ b/include/dt-bindings/thermal/tegra114-soctherm.h
> > @@ -0,0 +1,20 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +/*
> > + * This header provides constants for binding nvidia,tegra114-soctherm.
> > + */
> > +
> > +#ifndef _DT_BINDINGS_THERMAL_TEGRA114_SOCTHERM_H
> > +#define _DT_BINDINGS_THERMAL_TEGRA114_SOCTHERM_H
> > +
> > +#define TEGRA114_SOCTHERM_SENSOR_CPU 0
> > +#define TEGRA114_SOCTHERM_SENSOR_MEM 1
> > +#define TEGRA114_SOCTHERM_SENSOR_GPU 2
> > +#define TEGRA114_SOCTHERM_SENSOR_PLLX 3
> > +#define TEGRA114_SOCTHERM_SENSOR_NUM 4
> > +
> > +#define TEGRA_SOCTHERM_THROT_LEVEL_NONE 0
> > +#define TEGRA_SOCTHERM_THROT_LEVEL_LOW 1
> > +#define TEGRA_SOCTHERM_THROT_LEVEL_MED 2
> > +#define TEGRA_SOCTHERM_THROT_LEVEL_HIGH 3
>
> Please use the TEGRA114 prefix for these as well. I see that it's missing in
> the Tegra124 header, which is unfortunate.
>

Sure. I assume decision not to use TEGRA124 was intentional since
these defines are used in Tegra124, Tegra132 and Tegra210 device
trees.

> > +
> > +#endif
>
>
>
>