From: Thomas Zimmermann <tzimmermann@suse.de>
To: simona@ffwll.ch, airlied@gmail.com, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, geert@linux-m68k.org,
tomi.valkeinen@ideasonboard.com
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
nouveau@lists.freedesktop.org, virtualization@lists.linux.dev,
spice-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v6 12/25] drm/mediatek: Compute dumb-buffer sizes with drm_mode_size_dumb()
Date: Thu, 21 Aug 2025 10:17:19 +0200 [thread overview]
Message-ID: <20250821081918.79786-13-tzimmermann@suse.de> (raw)
In-Reply-To: <20250821081918.79786-1-tzimmermann@suse.de>
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
buffer size. Align the pitch to a multiple of 8.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_gem.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_gem.c b/drivers/gpu/drm/mediatek/mtk_gem.c
index a172456d1d7b..21e08fabfd7f 100644
--- a/drivers/gpu/drm/mediatek/mtk_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_gem.c
@@ -8,6 +8,7 @@
#include <drm/drm.h>
#include <drm/drm_device.h>
+#include <drm/drm_dumb_buffers.h>
#include <drm/drm_gem.h>
#include <drm/drm_gem_dma_helper.h>
#include <drm/drm_prime.h>
@@ -124,15 +125,9 @@ int mtk_gem_dumb_create(struct drm_file *file_priv, struct drm_device *dev,
struct mtk_gem_obj *mtk_gem;
int ret;
- args->pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
-
- /*
- * Multiply 2 variables of different types,
- * for example: args->size = args->spacing * args->height;
- * may cause coverity issue with unintentional overflow.
- */
- args->size = args->pitch;
- args->size *= args->height;
+ ret = drm_mode_size_dumb(dev, args, SZ_8, 0);
+ if (ret)
+ return ret;
mtk_gem = mtk_gem_create(dev, args->size, false);
if (IS_ERR(mtk_gem))
--
2.50.1
next prev parent reply other threads:[~2025-08-21 8:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 8:17 [PATCH v6 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 01/25] drm/dumb-buffers: Sanitize output on errors Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 02/25] drm/dumb-buffers: Provide helper to set pitch and size Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 03/25] drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb() Thomas Zimmermann
2025-11-25 14:39 ` Ludovic.Desroches
2025-11-25 15:03 ` Thomas Zimmermann
2025-11-26 6:24 ` Ludovic.Desroches
2025-11-26 7:40 ` Thomas Zimmermann
2025-11-26 9:29 ` Ludovic.Desroches
2025-08-21 8:17 ` [PATCH v6 04/25] drm/gem-shmem: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 05/25] drm/gem-vram: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 06/25] drm/armada: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 07/25] drm/exynos: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 08/25] drm/gma500: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 09/25] drm/hibmc: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 10/25] drm/imx/ipuv3: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 11/25] drm/loongson: " Thomas Zimmermann
2025-08-21 8:17 ` Thomas Zimmermann [this message]
2025-08-21 8:17 ` [PATCH v6 13/25] drm/msm: " Thomas Zimmermann
2025-11-02 16:39 ` Dmitry Baryshkov
2025-08-21 8:17 ` [PATCH v6 14/25] drm/nouveau: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 15/25] drm/omapdrm: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 16/25] drm/qxl: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 17/25] drm/renesas/rcar-du: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 18/25] drm/renesas/rz-du: " Thomas Zimmermann
2025-08-21 11:28 ` Biju Das
2025-08-21 11:55 ` Thomas Zimmermann
2025-08-21 12:34 ` Biju Das
2025-08-21 8:17 ` [PATCH v6 19/25] drm/rockchip: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 20/25] drm/tegra: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 21/25] drm/virtio: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 22/25] drm/vmwgfx: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 23/25] drm/xe: " Thomas Zimmermann
2025-09-29 15:25 ` Lucas De Marchi
2025-08-21 8:17 ` [PATCH v6 24/25] drm/xen: " Thomas Zimmermann
2025-08-21 8:17 ` [PATCH v6 25/25] drm/xlnx: " Thomas Zimmermann
2025-09-15 10:35 ` [PATCH v6 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821081918.79786-13-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=imx@lists.linux.dev \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
--cc=spice-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=virtualization@lists.linux.dev \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox