* [PATCH RESEND] PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate
@ 2025-10-13 13:18 Thorsten Blum
2025-10-13 16:58 ` Dmitry Osipenko
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-10-13 13:18 UTC (permalink / raw)
To: Dmitry Osipenko, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
Thierry Reding, Jonathan Hunter
Cc: Thorsten Blum, linux-pm, linux-tegra, linux-kernel
Use min() to improve the readability of actmon_cpu_to_emc_rate() and
remove any unnecessary curly braces.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/devfreq/tegra30-devfreq.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 4a4f0106ab9d..2c9813bd697e 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -12,6 +12,7 @@
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/irq.h>
+#include <linux/minmax.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -326,14 +327,9 @@ static unsigned long actmon_cpu_to_emc_rate(struct tegra_devfreq *tegra,
unsigned int i;
const struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios;
- for (i = 0; i < ARRAY_SIZE(actmon_emc_ratios); i++, ratio++) {
- if (cpu_freq >= ratio->cpu_freq) {
- if (ratio->emc_freq >= tegra->max_freq)
- return tegra->max_freq;
- else
- return ratio->emc_freq;
- }
- }
+ for (i = 0; i < ARRAY_SIZE(actmon_emc_ratios); i++, ratio++)
+ if (cpu_freq >= ratio->cpu_freq)
+ return min(ratio->emc_freq, tegra->max_freq);
return 0;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate
2025-10-13 13:18 [PATCH RESEND] PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate Thorsten Blum
@ 2025-10-13 16:58 ` Dmitry Osipenko
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Osipenko @ 2025-10-13 16:58 UTC (permalink / raw)
To: Thorsten Blum, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
Thierry Reding, Jonathan Hunter
Cc: linux-pm, linux-tegra, linux-kernel
13.10.2025 16:18, Thorsten Blum пишет:
> Use min() to improve the readability of actmon_cpu_to_emc_rate() and
> remove any unnecessary curly braces.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/devfreq/tegra30-devfreq.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 4a4f0106ab9d..2c9813bd697e 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -12,6 +12,7 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/irq.h>
> +#include <linux/minmax.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> @@ -326,14 +327,9 @@ static unsigned long actmon_cpu_to_emc_rate(struct tegra_devfreq *tegra,
> unsigned int i;
> const struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios;
>
> - for (i = 0; i < ARRAY_SIZE(actmon_emc_ratios); i++, ratio++) {
> - if (cpu_freq >= ratio->cpu_freq) {
> - if (ratio->emc_freq >= tegra->max_freq)
> - return tegra->max_freq;
> - else
> - return ratio->emc_freq;
> - }
> - }
> + for (i = 0; i < ARRAY_SIZE(actmon_emc_ratios); i++, ratio++)
> + if (cpu_freq >= ratio->cpu_freq)
> + return min(ratio->emc_freq, tegra->max_freq);
>
> return 0;
> }
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-13 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-13 13:18 [PATCH RESEND] PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate Thorsten Blum
2025-10-13 16:58 ` Dmitry Osipenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).