From: Akhil R <akhilrajeev@nvidia.com>
To: <andi.shyti@kernel.org>, <digetx@gmail.com>,
<jonathanh@nvidia.com>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<thierry.reding@gmail.com>, <wsa+renesas@sang-engineering.com>,
<wsa@kernel.org>
Cc: <kkartik@nvidia.com>, <akhilrajeev@nvidia.com>,
<ldewangan@nvidia.com>, <smangipudi@nvidia.com>
Subject: [PATCH v13 1/6] i2c: tegra: Do not configure DMA if not supported
Date: Tue, 18 Nov 2025 19:36:15 +0530 [thread overview]
Message-ID: <20251118140620.549-2-akhilrajeev@nvidia.com> (raw)
In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com>
From: Kartik Rajput <kkartik@nvidia.com>
On Tegra264, not all I2C controllers have the necessary interface to
GPC DMA, this causes failures when function tegra_i2c_init_dma()
is called.
Ensure that "dmas" device-tree property is present before initializing
DMA in function tegra_i2c_init_dma().
Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
---
v4 -> v9:
* Moved the condition down to have all dma checks together.
v2 -> v4:
* Add debug print if DMA is not supported by the I2C controller.
v1 -> v2:
* Update commit message to clarify that some I2C controllers may
not have the necessary interface to GPC DMA.
---
drivers/i2c/busses/i2c-tegra.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e533460bccc3..bd26b232ffb3 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -449,6 +449,11 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
if (IS_VI(i2c_dev))
return 0;
+ if (!of_property_present(i2c_dev->dev->of_node, "dmas")) {
+ dev_dbg(i2c_dev->dev, "DMA not available, falling back to PIO\n");
+ return 0;
+ }
+
if (i2c_dev->hw->has_apb_dma) {
if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
dev_dbg(i2c_dev->dev, "APB DMA support not enabled\n");
--
2.50.1
next prev parent reply other threads:[~2025-11-18 14:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 14:06 [PATCH v13 0/6] Updates for Tegra264 and Tegra256 Akhil R
2025-11-18 14:06 ` Akhil R [this message]
2025-11-27 9:29 ` [PATCH v13 1/6] i2c: tegra: Do not configure DMA if not supported Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 2/6] i2c: tegra: Use separate variables for fast and fastplus Akhil R
2025-11-27 9:30 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 3/6] i2c: tegra: Update Tegra256 timing parameters Akhil R
2025-11-27 9:31 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 4/6] i2c: tegra: Add HS mode support Akhil R
2025-11-18 14:19 ` Jon Hunter
2025-11-27 9:34 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 5/6] i2c: tegra: Add support for SW mutex register Akhil R
2025-11-27 9:36 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-18 14:06 ` [PATCH v13 6/6] i2c: tegra: Add Tegra264 support Akhil R
2025-11-27 9:36 ` Thierry Reding
2026-01-13 15:42 ` Wolfram Sang
2025-11-27 9:37 ` [PATCH v13 0/6] Updates for Tegra264 and Tegra256 Thierry Reding
2025-12-19 9:09 ` Akhil R
2026-01-06 6:28 ` Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118140620.549-2-akhilrajeev@nvidia.com \
--to=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox